Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus Not Obscured (aa/aaa): revise uses of 'hidden' #3533

Merged
merged 7 commits into from
Jan 18, 2024
Merged

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Nov 3, 2023

closes #3446

'hidden' is generally used to refer to content that is not presented to any user (e.g., display none) or 'hidden' from the accessibility tree (e.g., aria-hidden=true).

The current use of 'hidden' in the normative text / understanding doc mostly is meant to mean 'visually hidden/obscured' (though there is an instance of "hidden" in the understanding doc that was referring to the 'completely hidden' definition.

This PR changes instances of 'hidden' that meant 'visually hidden / visually obscured' to use these terms, instead of just 'hidden'.


Preview | Diff

closes #3446

'hidden' is generally used to refer to content that is not presented to any user (e.g., display none) or 'hidden' from the accessibility tree (e.g., aria-hidden=true).  

The current use of 'hidden' in the normative text / understanding doc _mostly_ is meant to mean 'visually hidden/obscured' (though there is an instance of "hidden" in the understanding doc that _was_ referring to the 'completely hidden' definition.

This PR changes instances of 'hidden' that meant 'visually hidden / visually obscured' to use these terms, instead of just 'hidden'.
hidden => visually hidden
hidden => visually hidden
change instance of 'hidden' to 'visually hidden' or 'obscured'
@scottaohara scottaohara marked this pull request as ready for review November 3, 2023 16:04
@scottaohara scottaohara changed the title Focus Not Obscured: revise uses of 'hidden' Focus Not Obscured (aa/aaa): revise uses of 'hidden' Nov 3, 2023
@mbgower
Copy link
Contributor

mbgower commented Nov 10, 2023

I'm concerned about the normative changes. I agree they're editorial, but my sense is the chance someone is going to wrongfully interpret this is pretty low, and the normative change isn't really warranted.
Is there any reason we cannot just update the Understanding documents

@patrickhlauke
Copy link
Member

i tend to agree with @mbgower here ... i don't think there's danger in leaving the normative text as is and just making sure the understanding document explicitly call out that this means visually hidden (from context, i'd say that's pretty clear, as this SC deals with a visual aspect)

@scottaohara
Copy link
Member Author

scottaohara commented Nov 10, 2023

That’s fair, but @mbgower we talked about this last week on the call and I asked if I should make the normative changes as well while we were on the call, and was told to go ahead. So it’s a bit odd to be told the opposite a week later. I guess there was a misunderstanding

I’ll revert those normative updates later today

@scottaohara
Copy link
Member Author

removed the normative updates, but still reference 'visually hidden' in the notes in each normative doc. should those be removed too? notes aren't normative, so i wouldn't have assumed so? but???

@mbgower mbgower merged commit 29376da into main Jan 18, 2024
1 check failed
@mbgower mbgower deleted the issue-3446 branch January 18, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The word "hidden" in the normative text of Focus Not Obscured may be confused with technology-specific uses
3 participants