Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pr3381 and pr3738 #3757

Merged
merged 172 commits into from
Apr 16, 2024
Merged

Merge pr3381 and pr3738 #3757

merged 172 commits into from
Apr 16, 2024

Conversation

fstrr
Copy link
Contributor

@fstrr fstrr commented Mar 25, 2024

Merges #3381 and #3738 to:

  • update / correct WCAG links
  • update resource links
  • add support for syntax highlighting
  • remove references to XHTML

Closes #3381
Closes #3738

* add syntax highlighting support
* fix broken link
* add support for syntax highlighting
* update one example
* added support for syntax highlighting
* updated resources link
* syntax highlighting
* replaced HTML 4.01 link to living standard
* support for syntax highlighting
* replaced HTML 4.01 link to living standard
* syntax highlighting
* replaced out of date resource link
Note: this technique should be retired. See: [issue 1234](#1234)
* add support for syntax highlighting
* update links from W3C HTML spec to WHATWG
* add lang support for change of languages
* removed references to XHTML and HTML5
* add support for syntax highlighting
* remove references to XHTML
* update Resources links
* remove test to check that `td` elements have `scope` attribute as that’s invalid HTML now
* swapped a male name for a female one
* add support for syntax highlighting
* remove references to HTML 4.01
Don’t need that if we’ve removed the change log list
Merges #3381 and #3738 to:

- update / correct WCAG links
- update resource links
- add support for syntax highlighting
Copy link
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admittedly didn't check out every single change, but on an initial high-level skim, this all looks kosher

@patrickhlauke
Copy link
Member

@fstrr merge conflicts resolved ... hope i didn't slip up while cherry-picking the bits (hoping we can merge this quickly before it goes out of sync this way again)

@fstrr
Copy link
Contributor Author

fstrr commented Apr 5, 2024

@patrickhlauke Thanks :) I had a quick skim, and it looks okay.

@mbgower @alastc Can we get this prioritized to get reviewed please? It's up to 196 pages, which is going to make it susceptible to more merge conflicts the longer it hangs around.

Copy link
Contributor

@mbgower mbgower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spot checked a number of files. All had correct changes.

@bruce-usab
Copy link
Contributor

Discussed on TF call 4/12 and Ready for approval.

@mbgower mbgower merged commit dd4939b into main Apr 16, 2024
1 check passed
@mbgower mbgower deleted the merge-pr3381-and-pr3738 branch April 16, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants