Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example aria role status #431

Merged
merged 30 commits into from
Aug 16, 2018
Merged

Example aria role status #431

merged 30 commits into from
Aug 16, 2018

Conversation

mbgower
Copy link
Contributor

@mbgower mbgower commented Jul 12, 2018

Submitting this pull request, along with the technique for aria-status-role, which I will cross-reference.

mbgower and others added 12 commits June 27, 2018 11:17
Provided alert demo for shopping cart.
Since there may be multiple working examples, moved first sample from index.html to a unique name
changing from role of alert to role of status. Also added in default values as well as more explanatory paragraph
Not sure I got the right number of hierarchical jumps right, but the links to the technique pages at least contain a valid target file.
@mbgower mbgower mentioned this pull request Jul 12, 2018
@alastc alastc added Techniques Ready for initial review A new technique ready for +1s or itterations labels Jul 13, 2018
mbgower and others added 7 commits July 13, 2018 11:06
Copy link
Member

@marcjohlic marcjohlic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few tweaks to the sample code, but both samples worked for me using iOS and VO.

@awkawk awkawk self-requested a review August 7, 2018 16:31
@alastc
Copy link
Contributor

alastc commented Aug 7, 2018

From the call 2018-08-07 this had 5 x +1s.

@alastc alastc added Ready for WG Review and removed Ready for initial review A new technique ready for +1s or itterations labels Aug 7, 2018
@detlevhfischer
Copy link
Contributor

detlevhfischer commented Aug 14, 2018

Removing aria-live and aria-atomic means (in my test page, http://3needs.org/en/testing/code/role-status.html , Example 2) that now, the context is no longer spoken in Firefox/NVDA - arguably a very important UA/AT combo.

@alastc alastc merged commit 8a674d4 into master Aug 16, 2018
@patrickhlauke patrickhlauke deleted the example-aria-role-status branch September 16, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants