Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example aria role log #436

Merged
merged 15 commits into from
Oct 2, 2018
Merged

Example aria role log #436

merged 15 commits into from
Oct 2, 2018

Conversation

mbgower
Copy link
Contributor

@mbgower mbgower commented Jul 18, 2018

@mbgower mbgower mentioned this pull request Jul 18, 2018
This was accidentally brought into this branch. it should not be here. The techniques are in separate branches.
@mbgower mbgower added Techniques Ready for initial review A new technique ready for +1s or itterations labels Jul 18, 2018
@awkawk awkawk self-requested a review July 24, 2018 15:14
@rachaelbradley rachaelbradley self-requested a review July 24, 2018 15:15
Copy link
Contributor

@rachaelbradley rachaelbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with

mbgower and others added 6 commits August 2, 2018 13:33
added notation saying the "aria-relevance" attribute is used just for demonstration purposes
Made Send button disabled after first use
I designated the conversation section as a dedicated space with some 10 rems, which should better display responsibly.
Added a fixed height (with rems) scrollable area for all log entries
Missed one piece of code to remove to make responsive work properly.
@awkawk awkawk merged commit 158c97c into master Oct 2, 2018
@awkawk awkawk deleted the example-aria-role-log branch October 2, 2018 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for initial review A new technique ready for +1s or itterations Techniques
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants