Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech failure orientation lock #545

Merged
merged 13 commits into from Apr 26, 2019
Merged

Conversation

@awkawk awkawk added Techniques Ready for initial review A new technique ready for +1s or itterations labels Dec 3, 2018
@mbgower
Copy link
Contributor

mbgower commented Dec 4, 2018

I feel like the test is missing one more test, which is whether the orientation changes as a device change of orientation occurs.

@detlevhfischer
Copy link
Contributor

detlevhfischer commented Dec 4, 2018

A typical case would be magnification users swivelling a device by 90 degrees to landscape to have longer lines for more convenient reading. So it is unclear to me whether content failing to respond to that orientation change on the fly would fail the SC - or if it is basically OK if it reflows only after re-loading the page. Many users may not know / realise that, so it would be at least a usability issue. (Not sure if the Understanding text is clear on this).
Change of orientation on the fly (turning the device by 90 degrees) seems a more convenient approach for testing but if immediate reponse is NOT required that would justif the more bitty approach in the test procedure now.

@brooksienoodlesoup
Copy link

It seems to me that if a user is looking to the Failure Technique as a way determining whether or not content fails because of a locked orientation, it would be important to consider whether or not the orientation is essential. So, my suggestion would be to add another step at the beginning of the procedure, such as "Ensure that one display orientation is not essential to the information or functionality of the content." Then, adjust the expected results to make it so that content that has an essential orientation doesn't fail.

@alastc
Copy link
Contributor

alastc commented Dec 4, 2018

On @brooksienoodlesoup point, the only example of a WCAG 2.0 failure for an SC with the 'essential' exception I could find is F16, and apart from the extraordinary long title, that aspect isn't mentioned.

I think (as David said on the call) that you can't refer to a technique for something which doesn't apply. At the SC level, if locking orientation is essential, it doesn't fall-through to the techniques, you get the exception at the SC level.

Perhaps it would be appropriate for the title to be "Failure due to locking the orientation to landscape or portrait view where it is not essential", and add something to the description.

E.g. the first line could be:

The objective of this technique is to describe how restricting the view of content to a single orientation is a failure unless it is for an essential purpose.

@awkawk
Copy link
Member Author

awkawk commented Dec 5, 2018

@mbgower Does the SC require that that orientation changes at any time, or would page load be sufficient?

@awkawk
Copy link
Member Author

awkawk commented Dec 5, 2018

@alastc it should still be in the procedure. I updated the procedure and added a sentence to the description.

@brooksienoodlesoup I updated for essential, but also expanded "control" in the last check to remind people that there may be user agent, OS, or device settings that should be checked.

@awkawk
Copy link
Member Author

awkawk commented Dec 5, 2018

@Ryladog I was thinking about your wall-mounted display comment from the call minutes. In that situation we are really talking about a closed system anyway and I wonder if adding that to this may confuse people?

@detlev - the reason I split the procedure is because I didn't think that we were saying that content needed to be able to rotate on the fly to orientation changes, and as a result I wanted to have "open the content" for each separate.

@jake-abma
Copy link
Contributor

I'm just having difficulty with the text as the sentences don't seem to be logical.
Suggest to rethink and shape the sentences a bit to be a bit more clear.

For example:

The objective of this technique is to describe how restricting the view of content to a single orientation is a failure to allow content to be viewed in multiple orientations.

"is to describe" can be deleted as this is what we do in a technique document.

... to allow content to be viewed...

Seems like another part of another sentence mixed with the previous part.

When content is presented in this way,

What way are we talking about here?

users must view the content in the orientation that the author selected.

Also here I need to read it multiple times to see what's meant.

with landscape and portrait display orientations

Reads a bit difficult, shouldn't it be "with landscape and portrait orientation modes"

@jake-abma
Copy link
Contributor

Also the procedure and expected results can be rewriting so it 'flows' better

@alastc alastc added Ready for publish and removed Ready for initial review A new technique ready for +1s or itterations labels Jan 3, 2019
@mbgower
Copy link
Contributor

mbgower commented Apr 1, 2019

I question the need to have the exception information in here. Looking at existing Failure techniques that apply to SCs where there is an exception, such as https://www.w3.org/TR/WCAG20-TECHS/failures#F54
I don't see any language about the exception in the failure technique. It seems to me that one only wants the failure technique to test failure, not the exception.
Someone can argue that a particular implementation meets the exception language, but at that point whether or not it fails is immaterial; it doesn't need to meet the SC.

@mbgower
Copy link
Contributor

mbgower commented Apr 1, 2019

@awkawk in regard to your #545 (comment) I think that the language of the SC means that testing dynamically is the simplest way to confirm the Failure.

  1. You confirm switches and OS settings to lock orientation are disabled
  2. You open content in one orientation and confirm content appears oriented correctly
  3. You rotate to the other and confirm content responds.

If 2 or 3 are not true, the failure applies.

@awkawk
Copy link
Member Author

awkawk commented Apr 26, 2019

Looks like it will need to be F97

@michael-n-cooper michael-n-cooper merged commit b786780 into master Apr 26, 2019
@awkawk
Copy link
Member Author

awkawk commented Apr 26, 2019

Thanks Michael.

@patrickhlauke patrickhlauke deleted the tech-failure-orientation-lock branch September 16, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants