Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In 1.4.11 Understanding text, adds field boundary exception when contrasty placeholder present #701

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

detlevhfischer
Copy link
Contributor

In section "Boundaries" the example used is a button that does not necessarily need a contrasty outline in text acts as indicator and has 4.5:1 or better contrast. The same is probably true for placeholder (contrast above 4.5:1) before a text field gets focused. I have just added that case (we had questions around that).

In section "Boundaries" the example used is a button that does not necessarily need a contrasty outline in text acts as indicator and has  4.5:1 or better contrast. The same is probably true for placeholder (contrast above 4.5:1) before a text field gets focused. I have just added that case (we had questions around that).
@detlevhfischer detlevhfischer changed the title Add field boundary exception when contrasty placeholder is used in section 'boundaries' Add field boundary exception when contrasty placeholder present in 1.4.11 Understanding text Apr 25, 2019
@detlevhfischer detlevhfischer changed the title Add field boundary exception when contrasty placeholder present in 1.4.11 Understanding text In 1.4.11 Understanding text, add field boundary exception when contrasty placeholder present Apr 25, 2019
@detlevhfischer detlevhfischer changed the title In 1.4.11 Understanding text, add field boundary exception when contrasty placeholder present In 1.4.11 Understanding text, adds field boundary exception when contrasty placeholder present Apr 25, 2019
@awkawk
Copy link
Member

awkawk commented Apr 28, 2019

Perhaps it would be better to say "there is no visual indication of the complete hit area" (adding "complete". There is an indication of the hit area in that the text provides it, just not the full extent.

@alastc alastc merged commit 2722fd6 into master Jun 4, 2019
@alastc alastc deleted the detlevhfischer-patch-2 branch June 4, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants