Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

G131 #830

Merged
merged 1 commit into from
Jul 23, 2019
Merged

G131 #830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions techniques/general/G131.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,15 @@ <h3>A form with required fields</h3>
</section>
</section><section id="tests"><h2>Tests</h2>
<section class="procedure"><h3>Procedure</h3>
<p>For each interface component in the content:</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this change makes sense for 2.4.6 this technique applies to SC 3.3.2 as well and this technique 131 is the foundation for other compound techniques (see the AND clause in understanding SC 3.3.2) and thus I think it is necessary for us to not assume a label is present and that the check needs to test to make sure a label is present. So I don't think we should change it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mraccess77 there is a note specifically about this already existing in the technique: "Note: This technique must be combined with other techniques to meet SC 3.3.2. See Understanding SC 3.3.2 for details."

G131 is about making existing labels clear, not about requiring a label to be present for every UI component. Confusion over the existing wording in the procedure is what initiated the issue. Remember that G131 can apply to things besides inputs -- things that are not required to have labels according to WCAG. Where a label in on an input, it is going to be covered by 3.3.2.

<p>For each interface component with a label:</p>
<ol>
<li>Identify the purpose of the interface component.</li>
<li>Check that any required label is present.</li>
<li>Check that each label makes the component's purpose clear.</li>
</ol>
</section>
<section class="results"><h3>Expected Results</h3>
<ul>
<li>Checks #2 and #3 are true.</li>
<li>Checks #2 is true.</li>
</ul>
</section>
</section><section id="related"><h2>Related Techniques</h2><ul>
Expand Down