Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text spacing update #860

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Text spacing update #860

merged 2 commits into from
Aug 27, 2019

Conversation

alastc
Copy link
Contributor

@alastc alastc commented Aug 13, 2019

Updates from Jim's doc, preview on rawgit, but viewing the files tab is probably easiest to see the changes.

The previous discussion led to asking LVTF to consider this, which is where this update came from. Agreeing to this would be closing the previous issue, and not agreeing to changing the SC text.

Closes #637, #635

<p>The intent of this Success Criterion (SC) is to ensure that people can override text spacing to improve their reading experience. Each of the requirements stipulated in the SC's four bullets helps ensure text styling can be adapted by the user to suit their needs.</p>
<p>This SC focuses on the ability to increase spacing between lines, words, letters, and paragraphs. Any combination of these may assist a user with effectively reading text. As well, ensuring users can override author settings for spacing also signficantly increases the likelihood other style preferences can be set by the user. For example, a user may need to change to a wider font family than the author has set in order to effectively read text. </p>
<p>The intent of this Success Criterion (SC) is to ensure that people can override author specified text spacing to improve their reading experience. Each of the requirements stipulated in the SC's four bullets helps ensure text styling can be adapted by the user to suit their needs.</p>
<p>The specified metrics set a minimum baseline. The values in between the author's metrics and the metrics specified in this SC should not have loss of content or functionality.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first reading, it sounds like the second sentence (about in-between values) follows on directly from the fist (mentioning the minimum baseline). But that's not really the case. Maybe the second sentence needs an "also" somewhere to make it clear this is an additional intention/requirement.

Also, later on under author responsibility the same first sentence is repeated, but there's a different follow-on. That looks odd/confusing. I'd say maybe remove this paragraph here, and add the second sentence from here to the one in author responsibility, to keep it all in one place - as it's the author's responsibility to also ensure that the in-between metrics work.

@awkawk awkawk merged commit 350d47c into master Aug 27, 2019
@WayneEDick
Copy link
Contributor

WayneEDick commented Aug 27, 2019 via email

@patrickhlauke patrickhlauke deleted the text-spacing-understanding-update branch September 19, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants