Further updates to 7.3.1.1 to fix broken links #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per following bullets in issue #147 2. In 7.3.1.1 Guidance When Applying “accessibility supported” to Non-Web Documents and Software. Link "assistive technologies" again looks OK (uses document anchor) but doesn't work in netlify version - it just opens the document at the start. https://deploy-preview-144--wcag2ict.netlify.app/#dfn-assistive-technologies MJM: change link reference to #dfn-assistive-technology 3. In 7.3.1.1 accessibility supported list. Link "user agents" doesn't work https://deploy-preview-144--wcag2ict.netlify.app/#dfn-user-agents. MJM: change link reference to #user-agent 4. In 7.3.1.1 Link "software" doesn't work https://deploy-preview-144--wcag2ict.netlify.app/#dfn-software MJM: change anchor to #software 5. In 7.3.1.1 Link "non-web document" doesn't work https://deploy-preview-144--wcag2ict.netlify.app/#dfn-non-web-document in "1. The way that the [non-web document " MJM: change link reference to #document 6. Link "software" doesn't work https://deploy-preview-144--wcag2ict.netlify.app/#dfn-software in "1. The way that the [non-web document "… MJM: I think this isn't the first link to the definition of software or non-web document, remove them. Only one link per definition is needed. 7. Link "technology" doesn't work https://deploy-preview-144--wcag2ict.netlify.app/#dfn-technologies in same section MJM: change link reference to #dfn-technology 8. Link "human language(s)" doesn't work https://deploy-preview-144--wcag2ict.netlify.app/#dfn-human-language in same section MJM: should link to full URL https://www.w3.org/TR/WCAG22/#dfn-human-language-s 9. Link "content" in the same section works as expected https://deploy-preview-144--wcag2ict.netlify.app/#dfn-content MJM: If this is the first link to the definition of content for the term "accessibility-supported" change the link to #content 10. Again, in bullet 2. The [non-web document or software] … Links are broken for non-web document, software, technology, software MJM: Remove these links. Links to these same terms already appear in the "accessibility-supported" definition - only need one. 11. Bullet 2.2. The technology is supported in a widely-distributed plug-in [or other software extension]. No link for other software extension - not sure if this is correct or not. MJM: Remove the link. A link to "technology" already appears in the "accessibility-supported" definition - only need one.
✅ Deploy Preview for wcag2ict ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
14 tasks
maryjom
previously approved these changes
May 19, 2023
Needed to remove the redundant links in accessibility-supported definitions again, as this PR and the other PR worked on the same line of code in the file.
I accidentally deleted to much.
maryjom
previously approved these changes
May 19, 2023
maryjom
approved these changes
May 19, 2023
github-actions bot
added a commit
that referenced
this pull request
May 19, 2023
SHA: e3d3445 Reason: push, by maryjom Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per following bullets in issue #147