Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proposed changes for closed functionality #254

Merged
merged 29 commits into from Feb 8, 2024

Conversation

maryjom
Copy link
Contributor

@maryjom maryjom commented Nov 2, 2023

Based on survey results, created this PR update to the proposed content.

The subsequent results from survey on updated closed functionality proposal resulted in some additional changes that I have incorporated into this PR. The latest survey from questions 4 on is reviewing the contents in this updated PR.

In addition, the approved changes from pull requests approved by TF in the 1 Feb. meeting have been incorporated into this PR / branch. One decision is left before we can merge this into the editor's draft: whether to use Option 1 or Option 2 in the Comments on Closed Functionality.

Based on survey results, creating an update to the proposed content.
Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for wcag2ict ready!

Name Link
🔨 Latest commit ed8306f
🔍 Latest deploy log https://app.netlify.com/sites/wcag2ict/deploys/65c51ae9b899620008998706
😎 Deploy Preview https://deploy-preview-254--wcag2ict.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@w3cbot
Copy link

w3cbot commented Nov 8, 2023

daniel-montalvo marked as non substantive for IPR from ash-nazg.

@w3cbot
Copy link

w3cbot commented Nov 8, 2023

deniak marked as substantive for IPR from ash-nazg.

We are only talking about software in the SC problematic for closed functionality. That's why "software" is used in the last paragraph. So I instead rephrased some and hopefully that matches the intent Shadi had in mind.
closed-functionality.md Outdated Show resolved Hide resolved
key-terms.md Outdated Show resolved Hide resolved
Update closed-functionality.md - modify examples for comments on clos…
Update key-terms.md - changes to closed functionality key term examples
@bruce-usab
Copy link
Contributor

A new user left a comment. This user must be approved by a Netlify team owner before comments can be displayed.

Approve this user

@maryjom
Copy link
Contributor Author

maryjom commented Feb 7, 2024

@bruce-usab I cannot see your comment on the proposed changes for closed functionality. Could you please send it to the group via email?

@ChrisLoiselle ChrisLoiselle self-assigned this Feb 8, 2024
@ChrisLoiselle
Copy link
Contributor

Commenting here from today's meeting, with request to Incorporate Option 1 from pull request 254 to finish the update to Comments on Closed Functionality. @maryjom happy to help here. Please let me know what file I should go in to to update. Not sure whether this is on the PR itself or tracked elsewhere.

bruce-usab
bruce-usab previously approved these changes Feb 8, 2024
@bruce-usab
Copy link
Contributor

@bruce-usab I cannot see your comment on the proposed changes for closed functionality. Could you please send it to the group via email?

Per call today, I am comfortable with Option 1.

@maryjom maryjom marked this pull request as ready for review February 8, 2024 18:25
@maryjom
Copy link
Contributor Author

maryjom commented Feb 8, 2024

@ChrisLoiselle All you need to do is approve the PR. I've already removed the proposal we didn't chose and ensured the document builds.

@maryjom maryjom merged commit 9f09c2e into main Feb 8, 2024
6 checks passed
github-actions bot added a commit that referenced this pull request Feb 8, 2024
SHA: 9f09c2e
Reason: push, by maryjom

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@maryjom maryjom deleted the mjm-2nd-proposal-closed branch February 8, 2024 18:52
@ChrisLoiselle ChrisLoiselle removed their assignment Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants