You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 7, 2018. It is now read-only.
Currently the things that get us out of the finished state are:
setting the current time (which will cause us to reach the third case)
setting the playback rate (which sets the current time)
reversing (which sets the playback rate)
setting the start time (which clears the hold time)
updating the timing of the effect (which will cause us to reach the third case)
cancelling (which clears the hold time)
updating the timeline (which clears the hold time)
There may be others, but those are the ones that come to mind.
I guess we need to add something to account for timelines that can go backwards. Perhaps within the "update the finished state" procedure instead of using the current time, we need to manually calculate the current time ignoring the hold time.
Subsequent experimentation by @theres-waldo suggests that we can fix this if we ignore the hold time when calculating the current time in the "update the finished state" procedure but only if did seek is false.
The text was updated successfully, but these errors were encountered:
… that change direction
This closes#173.
Generated from:
commit ea54539
Author: Brian Birtles <birtles@gmail.com>
Date: Mon Nov 28 16:49:30 2016 +0900
Adjust 'update the finished state' procedure to accommodate timelines that change direction
This closes#173.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The currently speced finishing behavior does not work well with timelines that go backwards.
From earlier email discussion with @theres-waldo:
Subsequent experimentation by @theres-waldo suggests that we can fix this if we ignore the hold time when calculating the current time in the "update the finished state" procedure but only if did seek is false.
The text was updated successfully, but these errors were encountered: