-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Definitions of Specific Resources: Example #138
Comments
see also related ticket: #139 |
Agree that this is an issue. The editorial issue is that by the time we get to just Section 4. (e.g. where the example is) we haven't introduced any of the specifiers (State, Selector, etc.) so it seems weird to have them in the example. I suggest the easiest and least confusing correction is to remove the example and the use case, but to leave the basic model components. Then have a note that functionally complete examples are in the sub-sections below. Would that satisfy the concern, @gsergiu? |
That is an option. Maybe it is not a bad idea to add also a "role" (purpose) to the example. In this case it would be ok to have "role" and "selector" in the example as the next two sections explain these properties. We can introduce references to the related sections in the introductory text. For me the following text looks like an summary of the section 4 ... (and I would place references on the State, Selector, Style, Scope, Role). The types of additional specificity that are available:
Sounds this like a good solution? |
Hi Rob, Mybe I'm to picky, but I would like ot ask why is the purpose a property of SpecificResources only and not any regular external resources? With regard to this I discovered a set of inconsitencies:
http://w3c.github.io/web-annotation/model/wd2/#motivation-and-purpose
So ... my suggestion would be se separate these concerns, otherwise they will get more and more confusing... I would suggest to consider the following representation for bodies: body : { Of course ther can be the minified representation ... body .. should have no @id as the body should be serialized only whitin the annotation. BR, |
Commenting with new proposals on a closed issue isn't a great way to ensure attention. Please raise new issues, one proposal per issue. To comment on the 3 points, however.... 1 & 2: The description of purpose as it relates to TextualBody could be better. I'll duplicate the description from the SpecificResource definition. 3: That's what a Specific Resource is. |
1&2 Well .. there is the principle in softare development, that the tester should not be the same person as the developer. It is common that fixing isues have side effects, in which case the isues are set back to "not fixed" status. I don't have the power to do this, but maybe you have it... if you find that my reports/arguments are correct. (Creating a new issues on the same topic is not the recommended way to handle such situations) with regard to 3. I agree that is what the class SpecificResourse is ... only that the name of the class is missleading. You will probalby not agree with that but there are arguments already written in the current version of the draft: Specific Reource: id I think that there is the contradiction in these definitions, the Specific class cannot restrict the "definition" from the Generic class. So ... external web resources must have an id and consequently, Anything that may not have an @id is not a Web Resource! b) All examples in the SpecificResources don't have an @id and consequently none of them is a (Web)Resource ! (they are simply sub-properties of the Annotation which is a web resource as it has an @id) c) I think I complained about this before, but the definition of the SpecificResource class doesn't really makes sense:
Of course that a SpecificResource is a class of a Specific Resource.... however it is not clear at all ... id the Specific Resource can be a Target, A Body or an ExternalWebResource? ... d) source: ```
|
In my opinion the example for specific resources is inconsistent with the introduction text in the
https://www.w3.org/TR/annotation-model/#specific-resources and with the WA Principles
https://www.w3.org/TR/annotation-model/#web-annotation-principles
Concretely, The introduction text says:
While it is possible using only the constructions in the core data model described above to create Annotations that reference parts of resources by using Fragment URIs, there are many situations when THIS IS NOT SUFFICIENT. For example, even a simple circular REGION of an image, or a diagonal line across it, are NOT POSSIBLE.
.......
For example, if the Target of the Annotation is a circular region of an image, then the SpecificResource is the circular region, it is described by a SELECTOR, and is also associated with the source Image resource.
{
"@id": "http://example.org/anno12",
"@type": "Annotation",
"body": {"@id": "http://example.org/comment1"},
"target": {
"@id": "http://example.org/region1",
"@type": "SpecificResource",
"source": "http://example.org/image1"
}
}
-- The resource with these constraints is a separate resource from the Annotation, Body or Target, and is called a SpecificResource.
-- The SpecificResource refers to the source resource and the constraints that make it more specific.
According to my understanding one of the following contraints must be present, otherwise is not a specific resource but a regular resource. Am I right?
The types of additional specificity that are available:
-- State: Describe the desired representation of the source resource for the Annotation
-- Selector: Describe the desired segment of the source resource for the Annotation
-- Style: Describe the style in which the source resource should be presented for the Annotation
-- Scope: Describe the scope in which the source resource applies for the Annotation
-- Role: Describe the role that the source resource plays for the Annotation
The text was updated successfully, but these errors were encountered: