Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow full SVG in SvgSelector? #17

Closed
azaroth42 opened this issue Feb 18, 2015 · 8 comments
Closed

Allow full SVG in SvgSelector? #17

azaroth42 opened this issue Feb 18, 2015 · 8 comments
Labels

Comments

@azaroth42
Copy link
Collaborator

Should the SvgSelector allow multiple shapes? (From Doug via annotation)

Discussion:
The rationale for this in the CG was that multiple non-overlapping/grouped shapes should probably be multiple targets, each with their own selector.

@tilgovi
Copy link
Contributor

tilgovi commented Feb 18, 2015

I could see multiple targets any of which may or may not have contiguous geometry. Why prevent it?

@stain
Copy link
Contributor

stain commented Feb 18, 2015

as long as it can be expressed in SVG, it should be fine. We can't make our own "SVG profiles" that requires shapes to be continuous or something.

@azaroth42
Copy link
Collaborator Author

The discussion during the CG was that multiple non-contiguous shapes should be separate targets in the model, to avoid multiple ways of expressing the same thing (multiple targets) and to ensure that each target region had the opportunity for identity (via the SpecificResource).

If we don't feel those are important distinctions to maintain, then we can drop the single shape requirement.

@stain
Copy link
Contributor

stain commented Apr 9, 2015

I think it becomes a difficult thing to enforce or check. What might at
first glance in the SVG look like non-contiguous, could be shown to be
contiguous in rendering - for instance a trianglethat is close to a circle

  • you will need to do precise calculations to see if it is a contiguous
    shape or not - but why should it matter?

Perhaps the best is to simply keep it as "Multiple non-contiguous shapes
SHOULD be separate targets, this ensures that each target region gets an
identity".

On 8 April 2015 at 15:56, Rob Sanderson notifications@github.com wrote:

The discussion during the CG was that multiple non-contiguous shapes
should be separate targets in the model, to avoid multiple ways of
expressing the same thing (multiple targets) and to ensure that each target
region had the opportunity for identity (via the SpecificResource).

If we don't feel those are important distinctions to maintain, then we can
drop the single shape requirement.


Reply to this email directly or view it on GitHub
#17 (comment).

Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons RDF (incubating)
http://orcid.org/0000-0001-9842-9718

@jjett
Copy link

jjett commented Apr 9, 2015

+1 for this. I agree that it will be hard to enforce, which makes me think
its within the boundaries of best practice rather than something the data
model can outright forbid.

On Thu, Apr 9, 2015 at 4:26 AM, Stian Soiland-Reyes <
notifications@github.com> wrote:

I think it becomes a difficult thing to enforce or check. What might at
first glance in the SVG look like non-contiguous, could be shown to be
contiguous in rendering - for instance a trianglethat is close to a circle

  • you will need to do precise calculations to see if it is a contiguous
    shape or not - but why should it matter?

Perhaps the best is to simply keep it as "Multiple non-contiguous shapes
SHOULD be separate targets, this ensures that each target region gets an
identity".

On 8 April 2015 at 15:56, Rob Sanderson notifications@github.com wrote:

The discussion during the CG was that multiple non-contiguous shapes
should be separate targets in the model, to avoid multiple ways of
expressing the same thing (multiple targets) and to ensure that each
target
region had the opportunity for identity (via the SpecificResource).

If we don't feel those are important distinctions to maintain, then we
can
drop the single shape requirement.


Reply to this email directly or view it on GitHub
#17 (comment).

Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons RDF (incubating)
http://orcid.org/0000-0001-9842-9718


Reply to this email directly or view it on GitHub
#17 (comment).

@pciccarese
Copy link
Contributor

I am inclined to agree with Stian point as well. It would be nice to have always the same behavior but if we cannot validate it easily we cannot enforce it either. I have not implemented SVG selectors myself so I would rather rely on the opinion of who did or tried to. For instance, I am not sure on what would happen to a client, which expects one shape only, when multiple shapes are defined in the same target.

@azaroth42
Copy link
Collaborator Author

So no change, and leave as a SHOULD/RECOMMEND. Fine by me. Will leave the issue open in case others want to chime in to disagree, but will close (wontfix) next week if there's no further discussion.

@azaroth42
Copy link
Collaborator Author

Resolved in October WD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants