Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a dokieli example #398

Merged
merged 2 commits into from Jan 23, 2017
Merged

Added a dokieli example #398

merged 2 commits into from Jan 23, 2017

Conversation

csarven
Copy link
Member

@csarven csarven commented Jan 22, 2017

This initial example is live from https://linkedresearch.org/annotation/csarven.ca/linked-data-notifications/decentralisation . I will clean it up to be a better for the spec.

@csarven
Copy link
Member Author

csarven commented Jan 23, 2017

I don't quite understand the check fail :)

@iherman
Copy link
Member

iherman commented Jan 23, 2017

(@csarven, do not worry about the error message, it is related to the patent policy. However, you're contributing to a note where this does not really apply. Took care of it.)

@iherman iherman requested a review from tcole3 January 23, 2017 09:56
@iherman iherman added this to the V1 Rec milestone Jan 23, 2017
Copy link
Contributor

@tcole3 tcole3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good example. A few notes:

  1. After merging, since in this example almost your entire html doc is essentially the annotation, and the target of annotation is in a separate html doc, I will edit the abstract and introduction accordingly. This is indeed one of the use cases we discussed.
  2. You will need to add text around the annotation describing how you serialized in RDFa, choices made, etc.
  3. It might be useful to actually include the distillation (in json-ld) of this example. I distilled using W3C RDFa 1.1 distiller and then framed using json-ld playground and the framing document from the vocab spec. Then manually edited to eliminate @graph layer and to remove the null value keys put in by the frame. Result passed all 54 Must tests and the other tests counted 14 optional features as implemented.
  4. May want to note that your application uses schema:creator (rather than dcterms:creator), schema:datePublished (rather than dcterms:created), etc. Just so people don't get confused.
  5. You might also want note how as an RDFa solution you used RDF properties rather than json-ld keys. E.g., @type, @value, etc. rather than corresponding keys. This did come up as part of issue 147, along with possible solution, but we haven't implemented yet.

@tcole3 tcole3 merged commit 706e0e4 into w3c:gh-pages Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants