Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update json-ld examples #401

Merged
merged 2 commits into from Jan 30, 2017
Merged

update json-ld examples #401

merged 2 commits into from Jan 30, 2017

Conversation

tcole3
Copy link
Contributor

@tcole3 tcole3 commented Jan 28, 2017

Updated json-ld examples and added text describing these examples;
Also updated abstract and introduction
@BigBlueHat if edits to abstract and introduction don't conflict with your work in progress, please merge.

Updated json-ld examples and added text describing these examples;
Also updated abstract and introduction
@tcole3
Copy link
Contributor Author

tcole3 commented Jan 28, 2017

Marked as non-substantive for IPR from ash-nazg.

@@ -436,64 +490,83 @@
"created": "2017-01-26T17:30:04.639Z",
"creator": {
"type": "Person",
"email": "mail-to:t-cole3@illinois.edu",
"name": "Tim Cole"
"email": "mail-to:mara@example.org",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Psuedo protocol is actually mailto:

@BigBlueHat
Copy link
Member

@tcole3 there's some good stuff in here, but some things I'd like to undo are:

  • text in the intro suggesting that one can only annotate "resources found on the Web"
    • the Model (and friends) are about annotating anything and a means to express those annotation on the Web
  • the inclusion of the Web Annotation Protocol mention is a bit distracting (the Note doesn't reference it agian)
  • I'd not put the media type in the intro...clutter-y

Otherwise, I think these are good changed.

Also, the addition of the use cases with links to places where they might be used is a great addition. Thank you!

- removed explicit media type+profile parameter from intro, but left reference to protocol since that is the only place the profile parameter is specified.  
- fixed mailto psuedo mime type
- add sub section for each json-ld example so would show up in TOC
@tcole3 tcole3 merged commit f5e9090 into w3c:gh-pages Jan 30, 2017
@BigBlueHat
Copy link
Member

@tcole3 changes look good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants