Editorial: Markdown/markup and link default tweaks #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* <aside> is a flow element; don't use it like a block. Use <div> * Use "note:" markdown, which Bikeshed styles better * Disambiguate "user agent" link
|
@saschanaz can can you review? (low priority) |
|
Perhaps escape |
saschanaz
approved these changes
May 31, 2023
index.bs
Outdated
| <aside class=note> | ||
| [=/Agents=] roughly correspond to windows (tabs), iframes, and workers. [=/Agent clusters=] correspond to independent processes in some user agent implementations. | ||
| </aside> | ||
| note: [=/Agents=] roughly correspond to windows (tabs), iframes, and workers. [=/Agent clusters=] correspond to independent processes in some user agent implementations. |
There was a problem hiding this comment.
I personally prefer NOTE: as that's the rendered result
| @@ -15,6 +15,10 @@ Markup Shorthands: css no, markdown yes | |||
| Assume Explicit For: yes | |||
| </pre> | |||
|
|
|||
| <pre class=link-defaults> | |||
| spec:infra; type:dfn; text:user agent | |||
There was a problem hiding this comment.
LINE ~146: Multiple possible 'user agent' dfn refs for '['/']'.
Arbitrarily chose https://infra.spec.whatwg.org/#user-agent
To auto-select one of the following refs, insert one of these lines into a <pre class=link-defaults> block:
spec:infra; type:dfn; text:user agent
The following refs show up multiple times in their spec, in a way that Bikeshed can't distinguish between. Either create a manual link, or ask the spec maintainer to add disambiguating attributes (usually a for='' attribute to all of them).
spec:css2; type:dfn; for:/; text:user agent
https://www.w3.org/TR/CSS21/conform.html#ua
https://www.w3.org/TR/CSS21/conform.html#user-agent
[=/user agent=]
There was a problem hiding this comment.
Sounds like CSS should be fixed, but okay.
github-actions bot
added a commit
that referenced
this pull request
May 31, 2023
SHA: 84a8cb1 Reason: push, by inexorabletash Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<aside>is a flow element; don't use it like a block. Use<div>Preview | Diff