Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use "script execution environment" #156

Closed
domenic opened this issue Sep 29, 2018 · 2 comments · Fixed by #178
Closed

Do not use "script execution environment" #156

domenic opened this issue Sep 29, 2018 · 2 comments · Fixed by #178
Labels
Origin Trial Issues that would be good to solve before OT

Comments

@domenic
Copy link
Contributor

domenic commented Sep 29, 2018

"script execution environment" is not a well-defined term. The spec links to https://html.spec.whatwg.org/#script-execution-environment which does not exist. It then seems to try to define it itself, but in a way that doesn't actually say what it is.

I'm not sure what the point of this term is, but it seems to be only used in the non-normative security policies section, plus once redundantly elsehwere ("Each Window object connected to the script execution environment" can just be "Each Window object") so hopefully it can be removed.
@kenchris kenchris added the Origin Trial Issues that would be good to solve before OT label Nov 30, 2018
@littledan
Copy link
Contributor

The NFC global state has to be associated with something or other. Would it make sense to hang it off the environment settings object?

@kenchris
Copy link
Contributor

kenchris commented Dec 5, 2018

Yes, we are moving towards using constructors and getting rid of the NFC interface, so we need somewhere to store the internal slots

littledan added a commit to littledan/web-nfc that referenced this issue Dec 5, 2018
@littledan
Editorial: Move state from the NFC interface to the settings object
9d2dbd8 
This refactoring should make it easier to change the interface to
NFCReader, to address w3c#152

Along the way, closes w3c#156.
@littledan littledan mentioned this issue Dec 5, 2018
Merged
littledan added a commit to littledan/web-nfc that referenced this issue Dec 6, 2018
@littledan
Editorial: Move state from the NFC interface to the settings object
d00a136 
This refactoring should make it easier to change the interface to
NFCReader, to address w3c#152

Along the way, closes w3c#156.
kenchris pushed a commit that referenced this issue Dec 6, 2018
@littledan @kenchris
Editorial: Move state from the NFC interface to the settings object
aaad6d1 
This refactoring should make it easier to change the interface to
NFCReader, to address #152

Along the way, closes #156.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Origin Trial Issues that would be good to solve before OT
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editorial: Move state from the NFC interface to the settings object littledan/web-nfc
3 participants
@littledan @domenic @kenchris