Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFCReader should contain those members of NFCReaderOptions? #219

Closed
leonhsl opened this issue May 5, 2019 · 3 comments · Fixed by #345
Closed

NFCReader should contain those members of NFCReaderOptions? #219

leonhsl opened this issue May 5, 2019 · 3 comments · Fixed by #345
Labels
Origin Trial Issues that would be good to solve before OT Spec issue

Comments

@leonhsl
Copy link
Contributor

leonhsl commented May 5, 2019

http://w3c.github.io/web-nfc/#constructing-an-nfcreader-object

For each key → value of options:
If key equals "url", set reader.[[Url]] to value.
Otherwise, if key equals "recordType", set reader.[[RecordType]] to value.
Otherwise, if key equals "mediaType", set reader.[[MediaType]] to value.
Otherwise, if key equals "compatibility", set reader.[[Compatibility]] to value.

However, NFCReader definition does not have such members: Url, RecordType, MediaType, and Compatibility.

@kenchris
Copy link
Contributor

kenchris commented May 5, 2019

These should be internal slots on NFCReader yes - we need a section listing the internal slots for the NFCReader object

@kenchris kenchris added the Origin Trial Issues that would be good to solve before OT label May 23, 2019
@leonhsl
Copy link
Contributor Author

leonhsl commented Sep 5, 2019

Now the new place for this problem is at http://w3c.github.io/web-nfc/#the-scan-method.

@Honry
Copy link
Contributor

Honry commented Sep 5, 2019

@leonhsl, @kenchris, I am working on it. :)

Honry added a commit to Honry/web-nfc that referenced this issue Sep 5, 2019
and make internal slots linkable

Fixed w3c#219
Honry added a commit to Honry/web-nfc that referenced this issue Sep 5, 2019
and make internal slots linkable

Fixed w3c#219
kenchris pushed a commit that referenced this issue Sep 5, 2019
and make internal slots linkable

Fixed #219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Origin Trial Issues that would be good to solve before OT Spec issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants