CanvasGradient#addColorStop should throw for invalid colors and offsets

web-platform-tests · Aug 11, 2015 · 3c73e05 · 3c73e05
1 parent 030b916
commit 3c73e05
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/2dcontext/fill-and-stroke-styles/2d.gradient.object.invalidoffset.html b/2dcontext/fill-and-stroke-styles/2d.gradient.object.invalidoffset.html
@@ -22,9 +22,9 @@ <h1>2d.gradient.object.invalidoffset</h1>
 var g = ctx.createLinearGradient(0, 0, 100, 0);
 assert_throws("INDEX_SIZE_ERR", function() { g.addColorStop(-1, '#000'); });
 assert_throws("INDEX_SIZE_ERR", function() { g.addColorStop(2, '#000'); });
-assert_throws("INDEX_SIZE_ERR", function() { g.addColorStop(Infinity, '#000'); });
-assert_throws("INDEX_SIZE_ERR", function() { g.addColorStop(-Infinity, '#000'); });
-assert_throws("INDEX_SIZE_ERR", function() { g.addColorStop(NaN, '#000'); });
+assert_throws(new TypeError(), function() { g.addColorStop(Infinity, '#000'); });
+assert_throws(new TypeError(), function() { g.addColorStop(-Infinity, '#000'); });
+assert_throws(new TypeError(), function() { g.addColorStop(NaN, '#000'); });
 
 
 });

diff --git a/2dcontext/tools/tests2d.yaml b/2dcontext/tools/tests2d.yaml
@@ -2013,9 +2013,9 @@
     var g = ctx.createLinearGradient(0, 0, 100, 0);
     @assert throws INDEX_SIZE_ERR g.addColorStop(-1, '#000');
     @assert throws INDEX_SIZE_ERR g.addColorStop(2, '#000');
-    @assert throws INDEX_SIZE_ERR g.addColorStop(Infinity, '#000');
-    @assert throws INDEX_SIZE_ERR g.addColorStop(-Infinity, '#000');
-    @assert throws INDEX_SIZE_ERR g.addColorStop(NaN, '#000');
+    @assert throws TypeError g.addColorStop(Infinity, '#000');
+    @assert throws TypeError g.addColorStop(-Infinity, '#000');
+    @assert throws TypeError g.addColorStop(NaN, '#000');
 
 - name: 2d.gradient.object.invalidcolour
   testing: