Throw a TypeError when get_callable_property encounters a value that …

…isn't callable.
web-platform-tests · Jun 23, 2015 · 5f5f6f8 · 5f5f6f8
1 parent 807559d
commit 5f5f6f8
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/dom/traversal/TreeWalker-acceptNode-filter.html b/dom/traversal/TreeWalker-acceptNode-filter.html
@@ -85,23 +85,21 @@
     assert_node(walker.currentNode, { type: Element, id: 'B1' });
 }, 'Testing with undefined filter');
 
-// XXX Servo breaks the test when a callback isn't callable
 test(function()
 {
     var walker = document.createTreeWalker(testElement, /*NodeFilter.*/SHOW_ELEMENT, {});
-    assert_throws(null, function () { walker.firstChild(); });
+    assert_throws(new TypeError(), function () { walker.firstChild(); });
     assert_node(walker.currentNode, { type: Element, id: 'root' });
-    assert_throws(null, function () { walker.nextNode(); });
+    assert_throws(new TypeError(), function () { walker.nextNode(); });
     assert_node(walker.currentNode, { type: Element, id: 'root' });
 }, 'Testing with object lacking acceptNode property');
 
-// XXX Servo breaks the test when a callback isn't callable
 test(function()
 {
     var walker = document.createTreeWalker(testElement, /*NodeFilter.*/SHOW_ELEMENT, { acceptNode: "foo" });
-    assert_throws(null, function () { walker.firstChild(); });
+    assert_throws(new TypeError(), function () { walker.firstChild(); });
     assert_node(walker.currentNode, { type: Element, id: 'root' });
-    assert_throws(null, function () { walker.nextNode(); });
+    assert_throws(new TypeError(), function () { walker.nextNode(); });
     assert_node(walker.currentNode, { type: Element, id: 'root' });
 }, 'Testing with object with non-function acceptNode property');