Skip to content

Commit

Permalink
multicol-zero-height-001-ref.xht produces 1px tall fragmentainers.
Browse files Browse the repository at this point in the history
The fragmentation spec says that fragmentainer heights should never be
shorter than 1px [1], so that we don't get stuck without content
progress. This means that if the multicol container's content box height
is 0, fragmentainers inside it will still be 1px. The ref depended on
incorrect behavior in Presto, where floats would never be fragmented.

[1] https://www.w3.org/TR/css-break-3/#breaking-rules

Bug: 788337
Change-Id: I96338070458a9df518d1b4bb70eee399bfde48ab
Reviewed-on: https://chromium-review.googlesource.com/821010
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523278}
  • Loading branch information
mstensho authored and chromium-wpt-export-bot committed Dec 12, 2017
1 parent ed4bb72 commit 9626f60
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 18 deletions.
8 changes: 2 additions & 6 deletions css/css-multicol/multicol-zero-height-001-ref.xht
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,8 @@
<title>CSS Reftest Reference</title>
<link rel="author" title="Opera Software ASA" href="http://www.opera.com/" />
<link rel="reviewer" title="Gérard Talbot" href="http://www.gtalbot.org/BrowserBugsSection/css21testsuite/" /> <!-- 2013-08-24 -->
<meta name="flags" content="image" />
<style type="text/css"><![CDATA[
img {vertical-align: top;}
]]></style>
</head>
<body>
<div><img src="support/swatch-lime.png" width="100" height="300" alt="Image download support must be enabled" /></div>
<div style="width:200px; height:1px; background-color:lime;"/>
</body>
</html>
</html>
18 changes: 6 additions & 12 deletions css/css-multicol/multicol-zero-height-001.xht
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<link rel="author" title="Opera Software ASA" href="http://www.opera.com/" />
<link rel="reviewer" title="Gérard Talbot" href="http://www.gtalbot.org/BrowserBugsSection/css21testsuite/" /> <!-- 2013-08-24 -->
<link rel="help" href="http://www.w3.org/TR/css3-multicol/#cw" title="3.1. 'column-width'" />
<link rel="help" href="https://www.w3.org/TR/css-break-3/#breaking-rules" title="4. Rules for Breaking" />
<link rel="match" href="multicol-zero-height-001-ref.xht" />
<meta name="flags" content="" />
<style type="text/css"><![CDATA[
Expand All @@ -14,25 +15,18 @@
orphans: 1;
widows: 1;
width: 200px;
border-bottom:1px solid red;

column-count: 2;
column-count: 10;
column-gap: 0;

/*

N == 2;

W == 100px;

*/
}

div > div
{
background-color: lime;
float: left;
height: 300px;
width: 100px;
height: 10px;
width: 100%;
}
]]></style>
</head>
Expand All @@ -41,4 +35,4 @@
<div></div>
</div>
</body>
</html>
</html>

0 comments on commit 9626f60

Please sign in to comment.