Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstreaming script type=module tests #4699

Open
domenic opened this issue Feb 2, 2017 · 3 comments
Open

Upstreaming script type=module tests #4699

domenic opened this issue Feb 2, 2017 · 3 comments
Labels

Comments

@domenic
Copy link
Member

domenic commented Feb 2, 2017

WebKit and Edge have written a lot of web platform tests for script type=module. It'd be really great if we could get them upstreamed to web-platform-tests so that everyone benefits from everyone else's coverage.

I think these should go under the category of "already reviewed upstream" so if their respective authors want to submit them as PRs to web-platform-tests, we should just rubber-stamp merge them immediately. Any review can be done as follow-up issues or PRs by reviewers. So for example we should not block merging these on Blink implementer review, but instead let Blink implementers try to pass them after they're already merged, and if Blink finds mistakes, Blink developers can send a follow-up PR.

/cc @rniwa, @AtOMiCNebula. Would you be willing to do the upstreaming?

@domenic
Copy link
Member Author

domenic commented Feb 2, 2017

Also worth noting is this test plan I put together which links out to individual WebKit and Edge tests that cover cases I thought of, plus contains a few items which I couldn't find tests for. https://docs.google.com/document/d/1ZfYUJG7tLvpJm1vleNfc5RoyoNx30NUNAOtnx_jhgRA/edit

@AtOMiCNebula
Copy link
Member

It seems our MicrosoftEdge/web-platform-tests repo isn't being kept up to date with w3c's. Dang! I'll try to figure out what's going on over there, this should have been merged into w3c's shortly after I merged in to MicrosoftEdge's.

@AtOMiCNebula
Copy link
Member

It sounds like we have some housekeeping issues going on in our clone. I rebased my change to get around a not-yet-upstreamed commit, see #4876.

@annevk annevk added the html label Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants