Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTCRtpContributingSource's audioLevel member should be double (asserted to be byte) #9108

Closed
foolip opened this issue Jan 19, 2018 · 1 comment
Closed

RTCRtpContributingSource's audioLevel member should be double (asserted to be byte) #9108

foolip opened this issue Jan 19, 2018 · 1 comment
Labels
type:missing-coverage webrtc wg-webrtc

Comments

@foolip
Copy link
Member

foolip commented Jan 19, 2018

These bits are out of sync with the spec:
https://github.com/w3c/web-platform-tests/blob/524bea1dd8d0ad58733072bd4e8b8044042f589e/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html#L64
https://github.com/w3c/web-platform-tests/blob/524bea1dd8d0ad58733072bd4e8b8044042f589e/webrtc/RTCRtpReceiver-getContributingSources.https.html#L77

Changed to double here:
w3c/webrtc-pc#1736

There are a few other occurrences of "audioLevel" too which probably should be updated.
@foolip foolip mentioned this issue Jan 19, 2018
Closed
@dontcallmedom
Copy link
Contributor

the tests with regard to type were aligned in a7ddc68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:missing-coverage webrtc wg-webrtc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dontcallmedom @foolip