Web Animations: remove timing objects #10171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 25, 2018
Build PASSEDStarted: 2018-04-05 13:38:21 View more information about this build on: |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-975923
branch
4 times, most recently
from
c9dd4eb
to
63a6754
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-975923
branch
3 times, most recently
from
1c1c545
to
8d34c89
Compare
The upstream spec has removed the 'timing' objects and replaced them with updateTiming/getTiming methods on AnimationEffect. It also removed and renamed a few timing idl interfaces; see the bug for full details. This CL also refactors the timing input parsing, aiming to make the public TimingInput API match what the spec requires and not expose other unnecessary methods. See w3c/csswg-drafts#2432 for the spec change. Bug: 823384, 823386 Change-Id: I40c82e46be29c16e2e4b53d69bbadc95c8bff324 Reviewed-on: https://chromium-review.googlesource.com/975923 Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#548403}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-975923
branch
from
8d34c89
to
9ab15c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream spec has removed the 'timing' objects and replaced them
with updateTiming/getTiming methods on AnimationEffect. It also removed
and renamed a few timing idl interfaces; see the bug for full details.
This CL also refactors the timing input parsing, aiming to make the
public TimingInput API match what the spec requires and not expose
other unnecessary methods.
See w3c/csswg-drafts#2432 for the spec change.
Bug: 823384, 823386
Change-Id: I40c82e46be29c16e2e4b53d69bbadc95c8bff324
Reviewed-on: https://chromium-review.googlesource.com/975923
Reviewed-by: Robert Flack flackr@chromium.org
Reviewed-by: Xida Chen xidachen@chromium.org
Commit-Queue: Stephen McGruer smcgruer@chromium.org
Cr-Commit-Position: refs/heads/master@{#548403}