Cookie Store: Consolidate WPT coverage for special prefixed cookies #10293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 3, 2018
Build PASSEDStarted: 2018-04-04 00:16:48 View more information about this build on: |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-994174
branch
3 times, most recently
from
8ae1e5a
to
7fd5f55
Compare
Merge two sets of tests that cover __Secure- and __Host- prefixed cookies in the API. Tests cover secure and non-secure contexts, getting, setting, deleting, and setting already-expired cookies. Bug: 729800 Change-Id: Ie7e84eeda03ba8192f5062cbf5240ff8ab13816a Reviewed-on: https://chromium-review.googlesource.com/994174 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#548562}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-994174
branch
from
7fd5f55
to
cb2d83f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge two sets of tests that cover __Secure- and __Host- prefixed
cookies in the API. Tests cover secure and non-secure contexts,
getting, setting, deleting, and setting already-expired cookies.
Bug: 729800
Change-Id: Ie7e84eeda03ba8192f5062cbf5240ff8ab13816a
Reviewed-on: https://chromium-review.googlesource.com/994174
Commit-Queue: Joshua Bell jsbell@chromium.org
Reviewed-by: Victor Costan pwnall@chromium.org
Cr-Commit-Position: refs/heads/master@{#548562}