Improve error message for exposure_set test #10337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`memberName` is undefined; error message is (was) `ReferenceError: memberName is not defined`.
Clearly supposed to be a check for duplication - `array.length < 0` was a really weird thing to see, though. Spec says it's always non-negative, so deleted that.
Error I see now is
"Multiple 'Exposed' extended attributes on Navigator"
lukebjerring
commented
Apr 5, 2018
| @@ -554,8 +554,9 @@ IdlArray.prototype.is_json_type = function(type) | |||
|
|
|||
| function exposure_set(object, default_set) { | |||
| var exposed = object.extAttrs.filter(function(a) { return a.name == "Exposed" }); | |||
| if (exposed.length > 1 || exposed.length < 0) { | |||
| throw new IdlHarnessError("Unexpected Exposed extended attributes on " + memberName + ": " + exposed); | |||
There was a problem hiding this comment.
Note also: 'exposed' prints as [Object object], [Object object], so is useless anyway.
foolip
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memberNameis undefined; error message is (was)ReferenceError: memberName is not defined.Clearly supposed to be a check for duplication -
array.length < 0was a really weird thing to see, though. Spec says it's always non-negative, so deleted that.Error I see now is
This change is