Cookie Store: Tentatively deflake special names test #10349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 6, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-999743
branch
2 times, most recently
from
cd86598
to
e7ae9a2
Compare
The "expires" cases are flaky on all platforms on the bots, although I can't reproduce locally. The test case sets a cookie that expires "now" then expects it can't read it. It may be flaky due to "now" being slightly different between processes, threads, and libraries, allowing the read to succeed. Set the expiry date to be an hour before "now", which should be sufficient. Bug: 829761 Change-Id: Icda1891310dd0a56769877f32405226390e729de Reviewed-on: https://chromium-review.googlesource.com/999743 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#548903}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-999743
branch
from
e7ae9a2
to
d4b686d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "expires" cases are flaky on all platforms on the bots, although
I can't reproduce locally. The test case sets a cookie that expires
"now" then expects it can't read it. It may be flaky due to "now"
being slightly different between processes, threads, and libraries,
allowing the read to succeed.
Set the expiry date to be an hour before "now", which should be
sufficient.
Bug: 829761
Change-Id: Icda1891310dd0a56769877f32405226390e729de
Reviewed-on: https://chromium-review.googlesource.com/999743
Commit-Queue: Joshua Bell jsbell@chromium.org
Reviewed-by: Victor Costan pwnall@chromium.org
Cr-Commit-Position: refs/heads/master@{#548903}