Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookie Store: Tentatively deflake special names test #10349

Merged
merged 1 commit into from Apr 6, 2018
Merged

Cookie Store: Tentatively deflake special names test #10349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion cookie-store/cookieStore_special_names.tentative.html
View file
Open in desktop
Expand Up @@ -23,7 +23,7 @@
testCase, new TypeError(),
cookieStore.set(
`${prefix}cookie-name`, `secure-cookie-value`, {
expires: Date.now()
expires: Date.now() - (24 * 60 * 60 * 1000)
}),
`Setting expired ${prefix} cookies should fail in non-secure contexts`);

Expand Down
5 changes: 4 additions & 1 deletion cookie-store/cookieStore_special_names.tentative.https.html
View file
Open in desktop
Expand Up @@ -20,9 +20,12 @@
}, `cookieStore.set with ${prefix} name on secure origin`);

promise_test(async testCase => {
// This test is for symmetry with the non-secure case. In non-secure
// contexts, the set() should fail even if the expiration date makes
// the operation a no-op.
await cookieStore.set(
`${prefix}cookie-name`, `secure-cookie-value`, {
expires: Date.now()
expires: Date.now() - (24 * 60 * 60 * 1000)
});
assert_equals(await cookieStore.get(`${prefix}cookie-name`), null);
try { await cookieStore.delete(`${prefix}cookie-name`); } catch (e) {}
Expand Down