WebAudio: Fix for WaveShaper "huge curve" test #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test previously had an even number of elements so the centre of the curve was actually mid-way between 2 elements (so I was using the wrong value used as the centre). I have now changed the curve to be an odd number of elements.
|
Critic review: https://critic.hoppipolla.co.uk/r/1764 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Looks good @pendragon-andyh, thanks! |
chrislo
added a commit
that referenced
this pull request
Jun 9, 2014
WebAudio: Fix for WaveShaper "huge curve" test
gsnedders
pushed a commit
that referenced
this pull request
Mar 28, 2017
Add pass if pass below reference and matches; r=Ms2ger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test previously had an even number of elements so the centre of the
curve was actually mid-way between 2 elements (so I was using the wrong
value used as the centre). I have now changed the curve to be an odd
number of elements.
Firefox nightly now has 100% passes.
This Pull Request replaces #1041. @chrislo requested that I spin-up a new branch and pull just a single commit.