[ForeignObject] Paint foreign objects during the foreground phase of normal-flow descendants. #11014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 15, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1060333
branch
5 times, most recently
from
684f7b6
to
d6b3bc0
Compare
…normal-flow descendants. When <foreignObject> was made a stacking context, it also had the side-effect of painting it at the same time as positioned elements. This is a change to painting order and caused a regression. Instead, implement a new mechanism by which a "replaced normal-flow stacking" element paints during the foreground phase of the LayoutObject paint tree walk. This is used for now just for <foreignObject>, but may be applied to other replaced elements such as iframes or embedded objects in the future. Bug:842668 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I450944986abfb6610084444abf2724e7406145cf Reviewed-on: https://chromium-review.googlesource.com/1060333 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#559401}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1060333
branch
from
d6b3bc0
to
f6af658
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When was made a stacking context, it also had the side-effect of
painting it at the same time as positioned elements. This is a change to painting
order and caused a regression. Instead, implement a new mechanism by which a
"replaced normal-flow stacking" element paints during the foreground phase
of the LayoutObject paint tree walk.
This is used for now just for , but may be applied to other
replaced elements such as iframes or embedded objects in the future.
Bug:842668
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I450944986abfb6610084444abf2724e7406145cf
Reviewed-on: https://chromium-review.googlesource.com/1060333
Commit-Queue: Chris Harrelson chrishtr@chromium.org
Reviewed-by: Tien-Ren Chen trchen@chromium.org
Cr-Commit-Position: refs/heads/master@{#559401}