remove race conditions from media-source/SourceBuffer-abort-* #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that other subtests are not affected when each modifies the video element.
|
Critic review: https://critic.hoppipolla.co.uk/r/3193 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
@karlt: note the comments on critic. |
karlt
force-pushed
the
SourceBuffer-abort-
branch
from
45ebc10
to
42d8d95
Compare
Requested by Philip Jägenstedt <philipj@opera.com>
Inspired by suggestion from Philip Jägenstedt <philipj@opera.com>.
karlt
force-pushed
the
SourceBuffer-abort-
branch
from
42d8d95
to
9398253
Compare
Requested by Philip Jägenstedt <philipj@opera.com>.
foolip
added a commit
that referenced
this pull request
Nov 19, 2014
remove race conditions from media-source/SourceBuffer-abort-*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1394