Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inexorabletash/encoding api #1523

Closed
wants to merge 1 commit into from
Closed

Inexorabletash/encoding api #1523

wants to merge 1 commit into from

Conversation

inexorabletash
Copy link
Contributor

Test for the Encoding Standard's API (TextEncoder/TextDecoder), ported from Chromium/Blink's layout tests.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/3713

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 13, 2015

@inexorabletash: something weird seems to have happened to the history here; could you try to squash everything into one simple commit?

@inexorabletash
Copy link
Contributor Author

@Ms2ger: Ugh, sorry - thought I had squashed.

Take a peek now? I'm not sure if I need to do more on the critic side of things.

@inexorabletash
Copy link
Contributor Author

Per the "...to help critic track your changes..." I may need to drop/resubmit a request. LMK.

@hillbrad
Copy link
Contributor

Critic is very confused by this, showing thousands of lines needing review. Is it possible to drop/resubmit this with just the relevant changes, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants