Add tests for HTMLTableSectionElement.deleteRow() and insertRow() #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Critic review: https://critic.hoppipolla.co.uk/r/4547 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Thank you for review @Ms2ger . I have improved them and call for review again |
|
@Ms2ger I have updated it to address your comments |
kangxu
force-pushed
the
html/the-tbody-element/add
branch
from
f01f13b
to
a099dd6
Compare
|
@Ms2ger I have squashed all the commits into one |
Ms2ger
added a commit
that referenced
this pull request
Jun 19, 2015
Add tests for HTMLTableSectionElement.deleteRow() and insertRow(); r=Ms2ger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.