Fix Worker_terminate_event_queue erroneous failure #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Worker_terminate_event_queue test checks that the last message received has the value 10000. However, the messages posted took values which are powers of 1000 + 1. This caused Worker_terminate_event_queue to always fail.
|
Critic review: https://critic.hoppipolla.co.uk/r/4801 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Ms2ger
added a commit
that referenced
this pull request
Apr 27, 2015
Fix Worker_terminate_event_queue erroneous failure; r=Ms2ger
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Worker_terminate_event_queue test checks that the last message received has the value 10,000 (see https://github.com/w3c/web-platform-tests/blob/master/workers/Worker_terminate_event_queue.htm). However, the messages posted took values which are powers of 1,000 + 1 causing Worker_terminate_event_queue to always fail. This patch fixes the worker to emit values at exact powers of 1,000.