Test for a no-media call. #1783
Conversation
This test verifies that a connection is established for a call where no media is added, but the initiator offers to receive video. The iceconnectionstate = connected indicator is used to determine that the connection is established.
|
Critic review: https://critic.hoppipolla.co.uk/r/4832 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
| <script src="/resources/testharnessreport.js"></script> | ||
| <script src="/common/vendor-prefix.js" | ||
| data-prefixed-objects= | ||
| '[{"ancestors":["navigator"], "name":"getUserMedia"}, |
There was a problem hiding this comment.
getUserMedia is not used, so no need to enable its prefixing
|
I've taken a first pass at commenting on the test case; also, the test times out in firefox (whereas it passes in Chrome) — not sure why yet. |
Used wrappers for the rest of callbacks, added TODO about using a promise-based API, addressed other comments.
|
PTAL |
| // Note: This test should have been as below, but second connection | ||
| // does not reach "completed". This is noted as an issue in the spec. | ||
| // https://github.com/w3c/webrtc-pc/issues/224 | ||
| if (gFirstConnection.iceConnectionState == 'completed' && |
There was a problem hiding this comment.
since w3c/webrtc-pc#224 is now closed (or about to be), that needs an update; if "completed" && "completed" is the expected outcome, we should only keep that version.
(I've since determined that the timeout in firefox I reported separately is due to it being stuck in "connected" / "connected" apparently)
Test now runs in Firefox, except that Firefox doesn't implement the oniceconnectionstatechange callback. There is a display on the test page for the state info, and the comment explaining the reason for early test termination has been expanded.
|
PTAL. Restored the prefixing, and also added a little more polish (as well as removed the video display tags that we don't use). One more Firefox issue found and bypassed (it doesn't queue createAnswer behind setLocalDescription). Also displayed what the status is at test end. |
| <script src="/common/vendor-prefix.js" | ||
| data-prefixed-objects= | ||
| '[{"ancestors":["window"], "name":"RTCPeerConnection"}, | ||
| {"ancestors":["window"], "name":"RTCSessionDescription"}]' |
There was a problem hiding this comment.
still misses one for RTCIceCandidate for Firefox sake
|
we're nearly there :) |
|
Great - I now have a test that works in Firefox 37.0.2 too - the last fix did it! |
Test for a no-media call.
This test verifies that a connection is established for a call where
no media is added, but the initiator offers to receive video.
The iceconnectionstate = connected indicator is used to determine
that the connection is established.
(This test submission is also a test on the review process for submitting new tests. Please give feedback as appropriate.)