Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed up the python code so these tests will run #1846

Closed
wants to merge 7 commits into from
Closed

Fixed up the python code so these tests will run #1846

wants to merge 7 commits into from

Conversation

thejohnjansen
Copy link
Contributor

Modified code throughout to get these tests running. Also added some stubs for tests soon to be added. Hopefully this pull request will be much easier to read than the previous.

John Jansen added 7 commits May 21, 2015 16:18
These changes enable the tests to run in all browsers plus add stubs for
some additional testing.
Conflicts:
	tools
	webdriver/base_test.py
	webdriver/cookie/cookie_test.py
	webdriver/element_location/element_location_test.py
	webdriver/element_state/method_test.py
	webdriver/element_state/visibility_test.py
	webdriver/javascript/execute_script_test.py
	webdriver/modal/alerts_quit_test.py
	webdriver/modal/alerts_test.py
	webdriver/navigation/auth_tests.py
	webdriver/navigation/forward.py
	webdriver/navigation/forwardToNothing.py
	webdriver/navigation/get_from_http_test.py
	webdriver/navigation/invalid_cert_test.py
	webdriver/timeouts/implicit_waits_tests.py
	webdriver/timeouts/page_load_timeouts_tests.py
	webdriver/user_input/clear_test.py
	webdriver/webdriver.cfg
This file got removed during my initial sync
Another file that accidentally got removed during my last fork
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/5081

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 9, 2015

@thejohnjansen, can you please revert the changes to html/semantics/grouping-content/the-li-element/grouping-li-novalue-manual.html and the resources and tools submodules, rebase on master, and squash all your commits?

@thejohnjansen
Copy link
Contributor Author

Closing this. I'm new to git and believe that the easiest way to resolve, squash, rebase, and revert is to try this again fresh. No one else has done any review, so I don't think this will waste any one's effort. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants