Use selection object in the same tree. #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current spec says (note: in non-normative section): https://w3c.github.io/webcomponents/spec/shadow/#ranges-and-selections > Accordingly, selections may only exist within one node tree, because > they are defined by a single range. The selection, returned by the > window.getSelection() method never returns a selection within a shadow > tree. This test used to use a Selection object from window.getSelection() to select a range in a shadow root, which failed. Instead, use getSelection() from the shadow root to select the range under the shadow root.
|
Critic review: https://critic.hoppipolla.co.uk/r/5558 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
@hayatoito PTAL |
hayatoito
added a commit
that referenced
this pull request
Jul 16, 2015
Use selection object in the same tree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test used Selection object from different TreeScope.
At this point the spec has some ambiguity, but at least if the test uses
a Selection object from the same TreeScope, it should work as expected.