Tests for Document#currentScript #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Critic review: https://critic.hoppipolla.co.uk/r/5698 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Comments on critic |
|
@jgraham updated few more tests, plz review! :) |
|
Squash? |
|
yes @jgraham i will, but after putting a few more test cases which are left to implement :) |
koustuvsinha
force-pushed
the
test#1636
branch
from
5b9e677
to
f5b5278
Compare
Following test cases have been added : * Nested script verification test * beforescriptexecute and afterscriptexecute tests * Script load fail verification test * verification within window.onerror test * verification in setTimeout and eval tests * Synchronous xhr verification test * script async & defer verification test * svg script verification test
koustuvsinha
force-pushed
the
test#1636
branch
from
f5b5278
to
b0e3047
Compare
jgraham
added a commit
that referenced
this pull request
Aug 12, 2015
Tests for Document#currentScript
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests for Document#currentScript according to issue #1636