Add Convert algorithm test of time #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Critic review: https://critic.hoppipolla.co.uk/r/181 This is an external review system which you may optionally use for the code review of your pull request. |
jgraham
added a commit
that referenced
this pull request
Apr 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the following to the test of time
· Convert a string to a number
milliseconds advanced from 00:00 When you type a letter in a valueAsNumber
· Convert a number to a string
milliseconds advanced from 00:00 If you enter a number valueAsNumber
· Convert a string to a Date
time If it is in proper format When you type a letter in a valueAsDate
· Convert a Date object to a string
Time of Date object If you set a Date object to valueAsDate
Is this the same specifications in the value property of the normal?