Fully implement the "align descendants" rule for div. #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds -servo-left and -servo-right to complement -servo-center. This intentionally doesn't try to address issue #7301.
|
Code reviewed upstream. |
Ms2ger
added a commit
that referenced
this pull request
Oct 12, 2015
…56e6cdaae7 Merge pull request #2244 from sync_b81c8717f3cfee77bcbdbc8bd10d3c56e6cdaae7
|
Critic review: https://critic.hoppipolla.co.uk/r/5884 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
| <html> | ||
| <head> | ||
| <meta charset=utf-8> | ||
| <link rel="match" href="div-align-ref.html"> |
There was a problem hiding this comment.
Shouldn't this line be in the div-align.html file instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds -servo-left and -servo-right to complement -servo-center.
This intentionally doesn't try to address issue #7301.