Align Fetch Request tests with WebKit ones #2549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Critic review: https://critic.hoppipolla.co.uk/r/6159 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
| var badJSONValues = ["undefined", "{", "a", "["]; | ||
| badJSONValues.forEach(function(value) { | ||
| promise_test(function(test) { | ||
| var request = new Request("", {"method": "POST", "body": "{"}); |
There was a problem hiding this comment.
This isn't using the test value as the body.
|
This looks fine with that one change made. |
jdm
added a commit
that referenced
this pull request
Feb 3, 2016
Align Fetch Request tests with WebKit ones
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new tests coming from WebKit:
Making some minor clean-up to some tests.