[eme] Simple EME playback and events #3359
Conversation
|
Reviewers for this pull request are: @ddorwin. |
|
Critic review: https://critic.hoppipolla.co.uk/r/6755 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
This PR is dependent on #3355 |
| runTest(config); | ||
| </script> | ||
| </body> | ||
| </html> |
There was a problem hiding this comment.
What's the purpose of clear key temporary playback events? Isn't temporary playback implicit for Clear Key delivery?
Also, how much of your new tests draw from the playback Clear Key tests in the Google folder? If we rename these, we'll need to do a test mapping exercise in the tracking document. Do you have a plan for doing that? Perhaps we should post the tracking document in this folder and have changes to it done per Pull Request?
There was a problem hiding this comment.
temporary-playback-events is basic playback with a temporary session and validation of the event sequence.
I expect that we will delete the Google folder. The plan was to migrate each of those tests into a generic script that could handle clear key + drm, mp4 and webm.
|
My main question has to do with updating tracing with new tests. The tests here seem reasonable to merge. LGTM. |
No description provided.