Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3756: Test that persistent licenses cannot be ingested into temp… #3774

Merged
merged 5 commits into from Sep 26, 2016

Conversation

mwatson2
Copy link
Contributor

…orary sessions

Copy link
Contributor

@AlexeyKor AlexeyKor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.then( function( supported )
{
// This test requires initData for supported content.
// We prefer explciit initData configured for the content, but
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: explciit -> explicit

<html>
<head>
<meta charset=utf-8>
<title>Encrypted Media Extensions: Events with DRM</title>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title doesn't reflect the content of the test.


config.messagehandler( event.messageType, event.message ).then( function( response ) {
mediaKeySession.update( response ).then( test.step_func( function() {
if ( event.messageType !== 'license-request' )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Add { }

@jdsmith3000
Copy link
Contributor

LGTM as well.

@mwatson2 mwatson2 merged commit 72bbf87 into web-platform-tests:master Sep 26, 2016
@AlexeyKor AlexeyKor mentioned this pull request Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants