Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eme] Add tests for rejecting improper licenses for the session type #3756

Closed
ddorwin opened this issue Sep 19, 2016 · 1 comment
Closed

Comments

@ddorwin
Copy link
Contributor

ddorwin commented Sep 19, 2016

The update() algorithm says the CDM should "Reject promise with a newly created TypeError" if a persistable license is provided to a session type other than "persistent-license" and vice versa.

The drmtoday server appears to request a different license based on a custom header (see getCustomHeaders() in drm-messagehandler.js), so we should be able to test these negative cases.

Note that failing this test could cause a key to be unexpectedly persisted, which could hide problems in other tests. It might be good to have a license with a key that does not appear in other tests.

@mwatson2 mwatson2 self-assigned this Sep 20, 2016
mwatson2 added a commit to mwatson2/web-platform-tests that referenced this issue Sep 20, 2016
@mwatson2
Copy link
Contributor

Pull Request #3774

This fails on Chrome, Firefox and Edge. I believe this is a known bug on Edge and that the license is indeed persistent. On Chrome and Firefox I don't know if the license gets persisted (and what the implications of this are) or whether it is treated just as a temporary license despite being marked as persistent.

Presently this is using a key also used for real content. This should be migrated to a different key if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants