Add some more tests of NodeList iterability #4663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome (unstable channel)Testing web-platform-tests at revision a077848 All results/dom/nodes/NodeList-Iterable.html
|
Firefox (nightly channel)Testing web-platform-tests at revision a077848 All results/dom/nodes/NodeList-Iterable.html
|
rniwa
reviewed
Jan 31, 2017
dom/nodes/NodeList-Iterable.html
Outdated
| } | ||
| } | ||
|
|
||
| assert_equals(total, 5); |
There was a problem hiding this comment.
Can we also confirm the order in which elements appear?
e.g. we can add class/id/title on each b to identify each b's.
Ms2ger
added
stale:awaiting-submitter-response
status:needs-changes
and removed
stale:awaiting-submitter-response
labels
domenic
force-pushed
the
nodelist-iterable
branch
from
7f2cb00
to
eafc8ef
Compare
|
No idea what the stability bot's problem is this time... |
domenic
force-pushed
the
nodelist-iterable
branch
from
eafc8ef
to
976f063
Compare
domenic
force-pushed
the
nodelist-iterable
branch
from
976f063
to
e1e3373
Compare
|
OK, bot problems were my bad messing up submodules. Good for a new review. |
|
r=me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from https://github.com/tmpvar/jsdom/blob/8b82e0c39bf856b072130e99cc60ca06ed75f7a7/test/living-dom/node-list.js.