Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to ensure FileReaderSync isn't supported in service workers. #4766

Merged

Conversation

mkruisselbrink
Copy link
Contributor

This was removed from the spec in w3c/FileAPI#16.

@wpt-pr-bot
Copy link
Collaborator

Notifying @ehsan. (Learn how reviewing works.)

These tests will be available shortly on w3c-test.org.

@mkruisselbrink
Copy link
Contributor Author

Possibly it makes more sense to add this to the FileAPI/historical.html test instead (and rename that to historical.https.html)...

@w3c-bots
Copy link

w3c-bots commented Feb 8, 2017

@w3c-bots
Copy link

w3c-bots commented Feb 8, 2017

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision f64dd7e
Using browser at version BuildID 20170314110401; SourceStamp 6d38ad302429c98115c354d643e81987ecec5d3c
Starting 10 test iterations
All results were stable

All results

1 test ran
/FileAPI/historical.https.html
Subtest Results Messages
OK
"toNativeLineEndings" should not be supported PASS
"FileError" should not be supported PASS
"FileException" should not be supported PASS
Blob should not support slice prefixed PASS
BlobBuilder should not be supported. PASS
createFor method should not be supported PASS
Blob.close() should not be supported PASS
Service worker test setup PASS
"FileReaderSync" should not be supported in service workers FAIL assert_false: expected false got true

@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 9, 2017

Possibly it makes more sense to add this to the FileAPI/historical.html test instead (and rename that to historical.https.html)...

Yes, I think so. Would you mind doing that?

@mkruisselbrink
Copy link
Contributor Author

I'll make that change. One reason I didn't originally was that it seemed a bit weird to have a file API test fall for service workers not being implemented. But this test does really belong there.

@mkruisselbrink
Copy link
Contributor Author

Okay, I moved the test to FileAPI/historical.https.html, but only run the service worker related tests if service workers are actually supported.

@w3c-bots
Copy link

These tests are now available on w3c-test.org

@mkruisselbrink
Copy link
Contributor Author

@Ms2ger are you happy with the current status of this PR?

@Ms2ger Ms2ger merged commit 5db343c into web-platform-tests:master Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants