Use .any.js for the getRandomValues() test. #4887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notifying @wafflespeanut, @engelke, and @jimsch. (Learn how reviewing works.) |
Chrome (unstable channel)Testing web-platform-tests at revision b8b8e4e |
Firefox (nightly channel)Testing web-platform-tests at revision b8b8e4e |
|
@Ms2ger Is this something that is a change based on how the platform works? Should this be done for the rest of the tests as well? |
|
It just reduces the boilerplate around running tests in both window and (dedicated) worker scopes. I think it's generally better to use this feature when writing tests for APIs that exist in both scopes, but rewriting existing tests is probably low priority. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.