Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOM] Fix null namespace handling in Node.isDefaultNamespace(). #5110

Merged
merged 1 commit into from Mar 10, 2017

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

  • Fix the implementation bug.
  • Remove obsolete test in the legacy DOM conformance tests.
  • Add tests for DocumentType node to WPT.

BUG=699812

Review-Url: https://codereview.chromium.org/2737273002
Cr-Commit-Position: refs/heads/master@{#456002}

- Fix the implementation bug.
- Remove obsolete test in the legacy DOM conformance tests.
- Add tests for DocumentType node to WPT.

BUG=699812

Review-Url: https://codereview.chromium.org/2737273002
Cr-Commit-Position: refs/heads/master@{#456002}
@wpt-pr-bot
Copy link
Collaborator

Notifying @ayg, @jdm, @zcorpan, and @zqzhang. (Learn how reviewing works.)

@wpt-pr-bot wpt-pr-bot added the dom label Mar 10, 2017
@w3c-bots
Copy link

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 72ed061
Using browser at version BuildID 20170306110339; SourceStamp 966464a68a2cb3ca1125808e34abb5c1d34e3797
Starting 10 test iterations
All results were stable

All results

1 test ran
/dom/nodes/Node-lookupNamespaceURI.html
Subtest Results Messages
OK
DocumentFragment should have null namespace, prefix null PASS
DocumentFragment should have null namespace, prefix "" PASS
DocumentFragment should have null namespace, prefix "foo" PASS
DocumentFragment should have null namespace, prefix "xmlns" PASS
DocumentFragment is in default namespace, prefix null PASS
DocumentFragment is in default namespace, prefix "" PASS
DocumentFragment is in default namespace, prefix "foo" PASS
DocumentFragment is in default namespace, prefix "xmlns" PASS
DocumentType should have null nemspace, prefix null PASS
DocumentType should have null namespace, prefix "" PASS
DocumentType should have null namespace, prefix "foo" PASS
DocumentType should have null namespace, prefix "xmlns" PASS
DocumentType is in default namespace, prefix null PASS
DocumentType is in default namespace, prefix "" PASS
DocumentType is in default namespace, prefix "foo" PASS
DocumentType is in default namespace, prefix "xmlns" PASS
Element should have null namespace, prefix null PASS
Element should have null namespace, prefix "" PASS
Element should not have namespace matching prefix with namespaceURI value PASS
Element should not have XMLNS namespace FAIL assert_equals: expected (object) null but got (string) "http://www.w3.org/2000/xmlns/"
Element has namespace URI matching prefix FAIL assert_equals: expected (string) "fooNamespace" but got (object) null
Empty namespace is not default, prefix null PASS
Empty namespace is not default, prefix "" PASS
fooNamespace is not default PASS
xmlns namespace is not default PASS
Element should have baz namespace, prefix null PASS
Element should have baz namespace, prefix "" PASS
Element does not has namespace with xlmns prefix FAIL assert_equals: expected (object) null but got (string) "http://www.w3.org/2000/xmlns/"
Element has bar namespace PASS
Empty namespace is not default on fooElem, prefix null PASS
Empty namespace is not default on fooElem, prefix "" PASS
bar namespace is not default PASS
baz namespace is default PASS
Comment should inherit baz namespace PASS
Comment should inherit baz namespace PASS
Comment should inherit namespace URI matching prefix FAIL assert_equals: expected (string) "fooNamespace" but got (object) null
Comment should inherit bar namespace PASS
For comment, empty namespace is not default, prefix null PASS
For comment, empty namespace is not default, prefix "" PASS
For comment, fooNamespace is not default PASS
For comment, xmlns namespace is not default PASS
For comment, inherited bar namespace is not default PASS
For comment, inherited baz namespace is default PASS
Child element should inherit baz namespace FAIL assert_equals: expected "childNamespace" but got "bazURI"
Child element should have null namespace FAIL assert_equals: expected "childNamespace" but got "bazURI"
Child element should not have XMLNS namespace FAIL assert_equals: expected (object) null but got (string) "http://www.w3.org/2000/xmlns/"
Child element has namespace URI matching prefix FAIL assert_equals: expected (string) "fooNamespace" but got (object) null
Empty namespace is not default for child, prefix null PASS
Empty namespace is not default for child, prefix "" PASS
fooNamespace is not default for child PASS
xmlns namespace is not default for child PASS
bar namespace is not default for child PASS
baz namespace is default for child FAIL assert_equals: expected false but got true
childNamespace is default for child FAIL assert_equals: expected true but got false
Document should have xhtml namespace, prefix null FAIL assert_equals: expected "http://www.w3.org/1999/xhtml" but got "bazURI"
Document should have xhtml namespace, prefix "" FAIL assert_equals: expected "http://www.w3.org/1999/xhtml" but got "bazURI"
Document has no namespace URI matching prefix PASS
Document has bar namespace PASS
For document, empty namespace is not default, prefix null PASS
For document, empty namespace is not default, prefix "" PASS
For document, fooNamespace is not default PASS
For document, xmlns namespace is not default PASS
For document, bar namespace is not default PASS
For document, baz namespace is not default FAIL assert_equals: expected false but got true
For document, xhtml namespace is default FAIL assert_equals: expected true but got false
Comment does not have bar namespace PASS

@w3c-bots
Copy link

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 72ed061
Using browser at version 58.0.3029.6 dev
Starting 10 test iterations
All results were stable

All results

1 test ran
/dom/nodes/Node-lookupNamespaceURI.html
Subtest Results Messages
OK
DocumentFragment should have null namespace, prefix null PASS
DocumentFragment should have null namespace, prefix "" PASS
DocumentFragment should have null namespace, prefix "foo" PASS
DocumentFragment should have null namespace, prefix "xmlns" PASS
DocumentFragment is in default namespace, prefix null FAIL assert_equals: expected true but got false
DocumentFragment is in default namespace, prefix "" FAIL assert_equals: expected true but got false
DocumentFragment is in default namespace, prefix "foo" PASS
DocumentFragment is in default namespace, prefix "xmlns" PASS
DocumentType should have null nemspace, prefix null PASS
DocumentType should have null namespace, prefix "" PASS
DocumentType should have null namespace, prefix "foo" PASS
DocumentType should have null namespace, prefix "xmlns" PASS
DocumentType is in default namespace, prefix null FAIL assert_equals: expected true but got false
DocumentType is in default namespace, prefix "" FAIL assert_equals: expected true but got false
DocumentType is in default namespace, prefix "foo" PASS
DocumentType is in default namespace, prefix "xmlns" PASS
Element should have null namespace, prefix null PASS
Element should have null namespace, prefix "" PASS
Element should not have namespace matching prefix with namespaceURI value PASS
Element should not have XMLNS namespace PASS
Element has namespace URI matching prefix PASS
Empty namespace is not default, prefix null FAIL assert_equals: expected true but got false
Empty namespace is not default, prefix "" FAIL assert_equals: expected true but got false
fooNamespace is not default PASS
xmlns namespace is not default PASS
Element should have baz namespace, prefix null PASS
Element should have baz namespace, prefix "" FAIL assert_equals: expected (string) "bazURI" but got (object) null
Element does not has namespace with xlmns prefix PASS
Element has bar namespace PASS
Empty namespace is not default on fooElem, prefix null PASS
Empty namespace is not default on fooElem, prefix "" PASS
bar namespace is not default PASS
baz namespace is default PASS
Comment should inherit baz namespace PASS
Comment should inherit baz namespace FAIL assert_equals: expected (string) "bazURI" but got (object) null
Comment should inherit namespace URI matching prefix PASS
Comment should inherit bar namespace PASS
For comment, empty namespace is not default, prefix null PASS
For comment, empty namespace is not default, prefix "" PASS
For comment, fooNamespace is not default PASS
For comment, xmlns namespace is not default PASS
For comment, inherited bar namespace is not default PASS
For comment, inherited baz namespace is default PASS
Child element should inherit baz namespace PASS
Child element should have null namespace FAIL assert_equals: expected (string) "childNamespace" but got (object) null
Child element should not have XMLNS namespace PASS
Child element has namespace URI matching prefix PASS
Empty namespace is not default for child, prefix null PASS
Empty namespace is not default for child, prefix "" PASS
fooNamespace is not default for child PASS
xmlns namespace is not default for child PASS
bar namespace is not default for child PASS
baz namespace is default for child PASS
childNamespace is default for child PASS
Document should have xhtml namespace, prefix null PASS
Document should have xhtml namespace, prefix "" FAIL assert_equals: expected (string) "http://www.w3.org/1999/xhtml" but got (object) null
Document has no namespace URI matching prefix PASS
Document has bar namespace PASS
For document, empty namespace is not default, prefix null PASS
For document, empty namespace is not default, prefix "" PASS
For document, fooNamespace is not default PASS
For document, xmlns namespace is not default PASS
For document, bar namespace is not default PASS
For document, baz namespace is not default PASS
For document, xhtml namespace is default PASS
Comment does not have bar namespace PASS

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 5b4c120 into master Mar 10, 2017
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-try branch March 10, 2017 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants