Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=169194 #5190

Closed
wants to merge 1 commit into from
Closed

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=169194 #5190

wants to merge 1 commit into from

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Mar 22, 2017 •
edited by wpt-pr-bot

The following changes since commit 51916ef:

Merge pull request #5189 from fippo/sld-test (2017-03-21 20:29:03 +0100)

are available in the git repository at:

https://github.com/youennf/web-platform-tests.git webkit-169194

for you to fetch changes up to bbb149e:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=169194 (2017-03-21 21:24:51 -0700)

Youenn Fablet (1):
WebKit export of https://bugs.webkit.org/show_bug.cgi?id=169194

fetch/api/cors/cors-preflight.js | 2 ++
1 file changed, 2 insertions(+)

diff --git a/fetch/api/cors/cors-preflight.js b/fetch/api/cors/cors-preflight.js
index e95a93f8de..55b524050e 100644
--- a/fetch/api/cors/cors-preflight.js
+++ b/fetch/api/cors/cors-preflight.js
@@ -99,4 +99,6 @@ corsPreflight("CORS [GET] [several headers], server refuses", corsUrl, "GET", fa
corsPreflight("CORS [PUT] [several headers], server allows", corsUrl, "PUT", true, headers, safeHeaders);
corsPreflight("CORS [PUT] [several headers], server refuses", corsUrl, "PUT", false, headers, safeHeaders);

+corsPreflight("CORS [PUT] [only safe headers], server allows", corsUrl, "PUT", true, null, safeHeaders);
+
done();

@wpt-pr-bot
Copy link
Collaborator

Notifying @annevk and @jdm. (Learn how reviewing works.)

@youennf youennf changed the title WebKit export of https://bugs.webkit.org/show_bug.cgi?169194 WebKit export of https://bugs.webkit.org/show_bug.cgi?id=169194 Mar 22, 2017
@w3c-bots
Copy link

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 28729538f4d838b0c8ef0c9823b4b34af1d56a5c
Using browser at version BuildID 20170320110254; SourceStamp 1b9293be51637f841275541d8991314ca56561a5
Starting 10 test iterations
All results were stable

All results

2 tests ran
/fetch/api/cors/cors-preflight-worker.html
Subtest Results Messages
OK
CORS [DELETE], server allows PASS {}
CORS [DELETE], server refuses PASS {}
CORS [PUT], server allows PASS {}
CORS [PUT], server refuses PASS {}
CORS [PATCH], server allows PASS {}
CORS [PATCH], server refuses PASS {}
CORS [NEW], server allows PASS {}
CORS [NEW], server refuses PASS {}
CORS [GET] [x-test-header: allowed], server allows PASS {}
CORS [GET] [x-test-header: refused], server refuses PASS {}
CORS [GET] [several headers], server allows PASS {}
CORS [GET] [several headers], server refuses PASS {}
CORS [PUT] [several headers], server allows PASS {}
CORS [PUT] [several headers], server refuses PASS {}
CORS [PUT] [only safe headers], server allows PASS {}
/fetch/api/cors/cors-preflight.html
Subtest Results Messages
OK
CORS [DELETE], server allows PASS
CORS [DELETE], server refuses PASS
CORS [PUT], server allows PASS
CORS [PUT], server refuses PASS
CORS [PATCH], server allows PASS
CORS [PATCH], server refuses PASS
CORS [NEW], server allows PASS
CORS [NEW], server refuses PASS
CORS [GET] [x-test-header: allowed], server allows PASS
CORS [GET] [x-test-header: refused], server refuses PASS
CORS [GET] [several headers], server allows PASS
CORS [GET] [several headers], server refuses PASS
CORS [PUT] [several headers], server allows PASS
CORS [PUT] [several headers], server refuses PASS
CORS [PUT] [only safe headers], server allows PASS

@w3c-bots
Copy link

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 28729538f4d838b0c8ef0c9823b4b34af1d56a5c
Using browser at version 59.0.3047.0 dev
Starting 10 test iterations
All results were stable

All results

2 tests ran
/fetch/api/cors/cors-preflight-worker.html
Subtest Results Messages
OK
CORS [DELETE], server allows PASS {}
CORS [DELETE], server refuses PASS {}
CORS [PUT], server allows PASS {}
CORS [PUT], server refuses PASS {}
CORS [PATCH], server allows PASS {}
CORS [PATCH], server refuses PASS {}
CORS [NEW], server allows PASS {}
CORS [NEW], server refuses PASS {}
CORS [GET] [x-test-header: allowed], server allows PASS {}
CORS [GET] [x-test-header: refused], server refuses PASS {}
CORS [GET] [several headers], server allows PASS {}
CORS [GET] [several headers], server refuses PASS {}
CORS [PUT] [several headers], server allows PASS {}
CORS [PUT] [several headers], server refuses PASS {}
CORS [PUT] [only safe headers], server allows PASS {}
/fetch/api/cors/cors-preflight.html
Subtest Results Messages
OK
CORS [DELETE], server allows PASS
CORS [DELETE], server refuses PASS
CORS [PUT], server allows PASS
CORS [PUT], server refuses PASS
CORS [PATCH], server allows PASS
CORS [PATCH], server refuses PASS
CORS [NEW], server allows PASS
CORS [NEW], server refuses PASS
CORS [GET] [x-test-header: allowed], server allows PASS
CORS [GET] [x-test-header: refused], server refuses PASS
CORS [GET] [several headers], server allows PASS
CORS [GET] [several headers], server refuses PASS
CORS [PUT] [several headers], server allows PASS
CORS [PUT] [several headers], server refuses PASS
CORS [PUT] [only safe headers], server allows PASS

@youennf youennf closed this Mar 22, 2017
@youennf youennf deleted the webkit-169194 branch March 22, 2017 04:40
@w3c-bots
Copy link

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 9b448987f6039ecacb22f0a5709f582e6782eaff
Using browser at version BuildID 20170320110254; SourceStamp 1b9293be51637f841275541d8991314ca56561a5
Starting 10 test iterations
All results were stable

All results

2 tests ran
/fetch/api/cors/cors-preflight-star-worker.html
Subtest Results Messages
OK
CORS that succeeds with credentials: false; method: GET (allowed: get); header: X-Test,1 (allowed: x-test) PASS {}
CORS that succeeds with credentials: false; method: SUPER (allowed: *); header: X-Test,1 (allowed: x-test) FAIL promise_test: Unhandled rejection with value: object "TypeError: NetworkError when attempting to fetch resource."
CORS that succeeds with credentials: false; method: OK (allowed: *); header: X-Test,1 (allowed: *) FAIL promise_test: Unhandled rejection with value: object "TypeError: NetworkError when attempting to fetch resource."
CORS that fails with credentials: true; method: OK (allowed: *); header: X-Test,1 (allowed: *) PASS {}
CORS that fails with credentials: true; method: PUT (allowed: *); header: undefined (allowed: ) PASS {}
CORS that fails with credentials: true; method: PUT (allowed: put); header: undefined (allowed: *) PASS {}
CORS that fails with credentials: true; method: GET (allowed: get); header: X-Test,1 (allowed: *) PASS {}
CORS that fails with credentials: true; method: GET (allowed: *); header: X-Test,1 (allowed: *) PASS {}
/fetch/api/cors/cors-preflight-star.html
Subtest Results Messages
OK
CORS that succeeds with credentials: false; method: GET (allowed: get); header: X-Test,1 (allowed: x-test) PASS
CORS that succeeds with credentials: false; method: SUPER (allowed: *); header: X-Test,1 (allowed: x-test) FAIL promise_test: Unhandled rejection with value: object "TypeError: NetworkError when attempting to fetch resource."
CORS that succeeds with credentials: false; method: OK (allowed: *); header: X-Test,1 (allowed: *) FAIL promise_test: Unhandled rejection with value: object "TypeError: NetworkError when attempting to fetch resource."
CORS that fails with credentials: true; method: OK (allowed: *); header: X-Test,1 (allowed: *) PASS
CORS that fails with credentials: true; method: PUT (allowed: *); header: undefined (allowed: ) PASS
CORS that fails with credentials: true; method: PUT (allowed: put); header: undefined (allowed: *) PASS
CORS that fails with credentials: true; method: GET (allowed: get); header: X-Test,1 (allowed: *) PASS
CORS that fails with credentials: true; method: GET (allowed: *); header: X-Test,1 (allowed: *) PASS

@w3c-bots
Copy link

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 9b448987f6039ecacb22f0a5709f582e6782eaff
Using browser at version 59.0.3047.0 dev
Starting 10 test iterations
All results were stable

All results

2 tests ran
/fetch/api/cors/cors-preflight-star-worker.html
Subtest Results Messages
OK
CORS that succeeds with credentials: false; method: GET (allowed: get); header: X-Test,1 (allowed: x-test) PASS {}
CORS that succeeds with credentials: false; method: SUPER (allowed: *); header: X-Test,1 (allowed: x-test) FAIL promise_test: Unhandled rejection with value: object "TypeError: Failed to fetch"
CORS that succeeds with credentials: false; method: OK (allowed: *); header: X-Test,1 (allowed: *) FAIL promise_test: Unhandled rejection with value: object "TypeError: Failed to fetch"
CORS that fails with credentials: true; method: OK (allowed: *); header: X-Test,1 (allowed: *) PASS {}
CORS that fails with credentials: true; method: PUT (allowed: *); header: undefined (allowed: ) PASS {}
CORS that fails with credentials: true; method: PUT (allowed: put); header: undefined (allowed: *) PASS {}
CORS that fails with credentials: true; method: GET (allowed: get); header: X-Test,1 (allowed: *) PASS {}
CORS that fails with credentials: true; method: GET (allowed: *); header: X-Test,1 (allowed: *) PASS {}
/fetch/api/cors/cors-preflight-star.html
Subtest Results Messages
OK
CORS that succeeds with credentials: false; method: GET (allowed: get); header: X-Test,1 (allowed: x-test) PASS
CORS that succeeds with credentials: false; method: SUPER (allowed: *); header: X-Test,1 (allowed: x-test) FAIL promise_test: Unhandled rejection with value: object "TypeError: Failed to fetch"
CORS that succeeds with credentials: false; method: OK (allowed: *); header: X-Test,1 (allowed: *) FAIL promise_test: Unhandled rejection with value: object "TypeError: Failed to fetch"
CORS that fails with credentials: true; method: OK (allowed: *); header: X-Test,1 (allowed: *) PASS
CORS that fails with credentials: true; method: PUT (allowed: *); header: undefined (allowed: ) PASS
CORS that fails with credentials: true; method: PUT (allowed: put); header: undefined (allowed: *) PASS
CORS that fails with credentials: true; method: GET (allowed: get); header: X-Test,1 (allowed: *) PASS
CORS that fails with credentials: true; method: GET (allowed: *); header: X-Test,1 (allowed: *) PASS

@annevk
Copy link
Member

annevk commented Mar 22, 2017

This was replaced with #5191?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fetch webkit-export
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@youennf @wpt-pr-bot @w3c-bots @annevk @foolip