Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ref tests for the dir attribute. #564

Closed

Conversation

NebuPookins
Copy link

http://www.w3.org/html/wg/drafts/html/CR/dom.html#the-dir-attribute

Reftest that exercises many parts of the dir attribute spec.

In particular, Chromium passes and Opera fails the test "If the element is an input element whose type attribute is in the Text, and the dir attribute is in the auto state, if the element's value contains a character of bidirectional character type AL and there is no character of bidirectional character type L anywhere before it in the element's value, then the directionality of the element is 'rtl'".

Both Chromium and Opera fail many tests, including "If the attribute is a directionality-capable attribute and the element's dir attribute is in the auto state, and the first character (in logical order) of the attribute's value that is of bidirectional character type L, AL, or R, is of bidirectional character type AL or R, the directionality of the attribute is 'rtl'."

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/646

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@NebuPookins
Copy link
Author

Some of the tests involve the rendering of SELECT dropdown boxes and the TITLE attribute (aka mouseover tooltips). Should the files be renamed to have "-manual.html" as a suffix?

@deniak
Copy link
Member

deniak commented Feb 13, 2014

@NebuPookins can you please address @Ms2ger's issue in critic?

@sideshowbarker
Copy link
Contributor

@NebuPookins this PR is waiting for responses from you to review comments

@sideshowbarker
Copy link
Contributor

This PR is still waiting review at https://critic.hoppipolla.co.uk/cd553dcc?review=646

@rniwa
Copy link
Contributor

rniwa commented Jan 31, 2017

I think we already have substantial test coverage for dir attribute in https://github.com/w3c/web-platform-tests/commits/master/html/dom/elements/global-attributes

Closing this PR issue since even if we didn't, we would have to split this test into smaller pieces to fit into 600px by 600px, and the submitter hasn't replied since July 2014.

@rniwa rniwa closed this Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants